Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CategorySharingFeature 액션 수정 #150

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

stealmh
Copy link
Member

@stealmh stealmh commented Oct 18, 2024

#️⃣연관된 이슈

#129

📝작업 내용

  • 액션 컨벤션에 맞춰 수정
  • computedProperty 일부 수정 (get 제거 및 컨벤션에 맞춤)

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@stealmh stealmh requested a review from ShapeKim98 October 18, 2024 05:09
@stealmh stealmh self-assigned this Oct 18, 2024
@stealmh stealmh added the Refactor 🏗️ 뚝딱뚝딱 코드 및 구조 수정 label Oct 18, 2024
@stealmh stealmh linked an issue Oct 18, 2024 that may be closed by this pull request
14 tasks
Copy link
Contributor

@ShapeKim98 ShapeKim98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

var category: CategorySharing.Category {
get { domain.sharedCategory.category }
}
var category: CategorySharing.Category { domain.sharedCategory.category }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get을 뺀 이유가 궁금합니다!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

computed에서 명시적으로 사용하지 않아도 한줄은 당연히 get로 인식이 되는게 익숙해서 뺐읍니다

@stealmh stealmh merged commit 3bc78c4 into develop Oct 20, 2024
1 check passed
@stealmh stealmh deleted the refactor/#129-CategorySharingFeature branch November 21, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor 🏗️ 뚝딱뚝딱 코드 및 구조 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

액션 컨벤션 정립
2 participants