feat: Form request API #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seokyeong237
reviewed
Feb 2, 2024
Comment on lines
29
to
30
| Carpool carpool = carpoolRepository.findByCarpoolIdAndIsDeleted(carpoolId, false) | ||
| .orElseThrow(() -> new CustomException(ErrorCode.NOT_EXIST_CARPOOL)); |
There was a problem hiding this comment.
CarpoolService์๋ findByCarpoolIdAndIsDeleted ํจ์๊ฐ ๋ฐ๋ณต๋ผ์ ์ฌ์ฉ๋๊ณ ์๋๋ฐ, CarpoolRepository์์ default method๋ก ์ข ๋ ๊น๋ํ๊ฒ ์ฌ์ฉํ๋ ๊ฑด ์ด๋จ๊น์??
ex)
default Member findByIdAndIsDeletedOrThrow(MemberId id, boolean isDeleted) {
return findByIdAndIsDeleted(id, isDeleted)
.orElseThrow(() -> new CustomException(ErrorCode.NOT_EXIST_USER));
}
There was a problem hiding this comment.
์ข์ ๋ฆฌ๋ทฐ ๊ฐ์ฌํฉ๋๋ค! ๋ฐ์ํ์ต๋๋ค~
Seokyeong237
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Summary
๐ฉโ๐ป Contents
๐ Review Note
๐ฃ Related Issue