Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: company selection api #35

Merged
merged 5 commits into from
Jan 30, 2024
Merged

feat: company selection api #35

merged 5 commits into from
Jan 30, 2024

Conversation

Seokyeong237
Copy link
Member

πŸ“ Summary

company selection api

πŸ‘©β€πŸ’» Contents

company selection api

πŸ“ Review Note

πŸ“£ Related Issue

@Seokyeong237 Seokyeong237 self-assigned this Jan 29, 2024
Park-Young-Hun
Park-Young-Hun reviewed Jan 30, 2024
View reviewed changes
src/main/java/com/fullcar/member/domain/member/Member.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엔티티와 λ°Έλ₯˜ κ°μ²΄λŠ” μ°Έμ‘° 투λͺ…μ„±κ³Ό λ©€ν‹°μŠ€λ ˆλ“œ ν™˜κ²½μ—μ„œμ˜ μ•ˆμ •μ„±μ„ μœ„ν•΄ Immutable 즉, λΆˆλ³€ 객체둜 κ΅¬ν˜„ν•˜λŠ”κ²Œ μ’‹λ‹€κ³  μƒκ°ν•©λ‹ˆλ‹€!
μžμ„Έν•œ λ‚΄μš©μ€ 도메인 주도 개발 μ‹œμž‘ν•˜κΈ° 50νŽ˜μ΄μ§€ ν•œλ²ˆ λ΄μ£Όμ„Έμš”!!

src/main/java/com/fullcar/member/domain/member/Company.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double νƒ€μž…μ€ λΆ€λ™μ†Œμˆ˜μ  ν‘œν˜„ 방식이기 λ•Œλ¬Έμ— 값에 μ˜€μ°¨κ°€ λ°œμƒν•˜κ²Œ λ˜λŠ”λ°μš”! 경도와 μœ„λ„λŠ” μžμ„Έν•œ 값을 μ €μž₯ν•˜κ³  κ³„μ‚°λ˜μ–΄μ•Ό ν•˜κΈ° λ•Œλ¬Έμ— BigDecimal νƒ€μž…μ„ μ‚¬μš©ν•˜λŠ” 것을 μΆ”μ²œλ“œλ¦½λ‹ˆλ‹€!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λͺ¨λ‘ λ°˜μ˜μ™„λ£Œν–ˆμ–΄μš”~!!

Park-Young-Hun
Park-Young-Hun approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@Park-Young-Hun Park-Young-Hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€~!

@Seokyeong237 Seokyeong237 merged commit 09cee48 into develop Jan 30, 2024
1 check passed
@Seokyeong237 Seokyeong237 deleted the feat/ISSUE-30 branch February 13, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Park-Young-Hun Park-Young-Hun Park-Young-Hun approved these changes

Assignees

@Seokyeong237 Seokyeong237

Labels
feat πŸ²μ„œκ²½πŸ²
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: company selection API
2 participants
@Seokyeong237 @Park-Young-Hun