Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: car registration api #26

Merged
merged 4 commits into from
Jan 23, 2024
Merged

feat: car registration api #26

merged 4 commits into from
Jan 23, 2024

Conversation

Seokyeong237
Copy link
Member

πŸ“ Summary

Implemented car registration api

πŸ‘©β€πŸ’» Contents

  • Implemented car registration API
  • You might see a bunch of files changed. It's because I refactored auth and car in the member server.
  • I set the name of the id in car tables as car_id. Because there was a duplication error in the member domain.

πŸ“ Review Note

πŸ“£ Related Issue

Copy link
Member

@Park-Young-Hun Park-Young-Hun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ‹€λ₯Έ ν…Œμ΄λΈ”λ“€μ˜ μ‹λ³„μž Column λͺ…을 "id"둜 ν•˜κ³  μžˆμ–΄μ„œ 톡일이 ν•„μš”ν•΄ λ³΄μž…λ‹ˆλ‹€!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν…μŠ€νŠΈ κΈ€μžμˆ˜ μ œν•œκ³Ό λ™μΌν•œ λ§₯락으둜 ν•„μˆ˜ μž…λ ₯μ΄λΌλŠ” λΉ„μ¦ˆλ‹ˆμŠ€ μš”κ΅¬μ‚¬ν•­μ€ 자주 λ³€ν•  수 μžˆλŠ” μš”κ΅¬μ‚¬ν•­μ΄κΈ° λ•Œλ¬Έμ— 도메인 λͺ¨λΈμ— μ§μ ‘μ μœΌλ‘œ λ°˜μ˜ν•˜κΈ°λ³΄λ‹¨ ν΄λΌμ΄μ–ΈνŠΈμ—μ„œ μ˜ˆμ™Έμ²˜λ¦¬ν•˜λ„λ‘ ν•˜κ³  μ„œλ²„μ—μ„œλŠ” λΉ„μ¦ˆλ‹ˆμŠ€ λ‘œμ§μ— 영ν–₯을 μ£ΌλŠ” ν•„λ“œλ§Œ(ex- μ‹λ³„μž λ“±) Null check ν•˜λŠ”κ²Œ 더 μ’‹λ‹€κ³  μƒκ°ν•©λ‹ˆλ‹€!! 근데 개인적 생각이고 크게 μ€‘μš”ν•œ 뢀뢄은 μ•„λ‹ˆλΌ ꡳ이 μ•ˆλ°”κΎΈμ…”λ„ 되고 κ·Έλƒ₯ μƒκ°λ§Œ κ³΅μœ ν•˜κ³  μ‹Άμ—ˆμ–΄μš”!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음 ν…μŠ€νŠΈ κΈ€μžμˆ˜ μ œν•œμ€ λ™μ˜ν•˜λŠ”λ°μš”! ν•„μˆ˜ μž…λ ₯ 같은 κ²½μš°λŠ” 검증을 ν•˜μ§€ μ•ŠμœΌλ©΄ ν”„λ‘ νŠΈμ—μ„œ 잘λͺ»λœ 데이터λ₯Ό μ„œλ²„μ— λ„£μ—ˆμ„ λ•Œ 데이터 λ³€μ‘°κ°€ 일어날 μˆ˜λ„ μžˆλ‹€λŠ” μ μ—μ„œ ν”„λ‘ νŠΈ, λ°± λͺ¨λ‘μ—μ„œ ν•΄μ€˜μ•Ό μ•ˆμ „ν•˜λ‹€κ³  μƒκ°ν•΄μš”!!

https://techblog.woowahan.com/2645/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AttributeOverrides(
@AttributeOverride(name = "id", column = @column(name = "car_id"))
)
private CarId carId;

μœ„μ™€ 같이 컬럼λͺ…을 λ°”κΏ€ 수 μžˆλ‹€κ³  ν•©λ‹ˆλ‹€!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ™• κ°μ‚¬ν•©λ‹ˆλ‹Ή

@Seokyeong237 Seokyeong237 merged commit 977194c into develop Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: car information registration API
2 participants