Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1차 payple 연동 #128

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

feat: 1차 payple 연동 #128

wants to merge 7 commits into from

Conversation

Jeong-jeong
Copy link
Contributor

🧑‍💻 PR 내용

📸 스크린샷

🧐 논의할 점

@Jeong-jeong Jeong-jeong self-assigned this Jul 10, 2022
@Jeong-jeong Jeong-jeong marked this pull request as ready for review July 11, 2022 14:55
Comment on lines +7 to +8
VITE_TEST_PAYMENT_REFERER=http://localhost:3000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 아마 .env.production에도 추가해야 리얼에서 환경변수 에러 안날것 같아요!

@@ -0,0 +1,2 @@
export const SERVER_URL = import.meta.env.VITE_SERVER_URL;
export const PAYMENT_URL = import.meta.env.VITE_TEST_PATMENT_URL;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -15,6 +15,9 @@
<body>
<div id="root"></div>
<div id="modal-root"></div>

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제이쿼리 슬프네요 ㅜㅜ

import { SERVER_URL } from '../constants';
import { PartnerAuth } from '@/types/payment';

export const getPartnerAuth = async (): Promise<PartnerAuth | undefined> => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저번에 급하게 하느라 그냥 넣었는데 저희 api 다 이런식으로 묶어서 쓰는거로 바꿔야겠네요..!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants