Signal handling issues #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dbus-watch thread has a very short interval between process_discard
calls - 1ms, that is lead to excessive overhead at the DBus at all.
At an other hand this is unnecessary, because the claimed accuracy is
not required.
The patch increases timeout between process_discard to the 20ms and
DBusWindowCall to the 500us (consequential change).
End-user-impact: Now dbus-requests that have direct calls to the dbus
handling a little bit quickly, the total cpu/memory
usage are decreased.
Signed-off-by: Igor Kononenko <[email protected]>
The patch change a way to determinate DBusInstance target interfaces which uses to obtain relevant SearchPropertyCriteria. Now, the used memory of each DBusInstance reduced. End-user-impact: None (now yaweb uses less memory). Signed-off-by: Igor Kononenko <[email protected]>
The GraphQL implementation doesn't cary about exceptions that may incoming on data-filling process. The patch add catching of nlohmann::json exceptions. End-user-impact: Now, yaweb server more stable. Signed-off-by: Igor Kononenko <[email protected]>
Currently the protection of accessing to internal DBusInstance non-threadsafe resources performs via methods `instanceAccessGuardLock` and `instanceAccessGuardUnlock`. There is more correct method to provide resource protection via RAII abstraction. The patch brings AccessGuard class that is incapsulate mentioned methods and provide more userfriendly API to protect resources. Additionally the patch adds protection for `actualInterfaces` class-field accessing. End-user-impact: None (internal API enhancement) Signed-off-by: Igor Kononenko <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch fixes several issues: