-
Notifications
You must be signed in to change notification settings - Fork 1
redfish: Add redfish schemas only from implementation and oem #23
Open
serge4k
wants to merge
4
commits into
master
Choose a base branch
from
feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
redfish: Add redfish schemas only from implementation and oem #23
serge4k
wants to merge
4
commits into
master
from
feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serge4k
force-pushed
the
feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem
branch
2 times, most recently
from
February 21, 2023 09:08
812fcbe
to
f9fa915
Compare
Implemented logic inside the "redfish-gen" tool to prepare schemas based on BMC implementation and Oem schemas necessary for the "Redfish Service Validator" tool. Part of BBMC-1462 End-User-Impact: Low: (The BMC's redfish service may be validated by the "Redfish Service Validator" tool) Signed-off-by: Sergey Gulyaev <[email protected]>
serge4k
force-pushed
the
feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem
branch
from
February 21, 2023 09:31
f9fa915
to
b24a80a
Compare
ikmsk10
suggested changes
Feb 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Codacy has several warnings, please fix them.
Create common Redfish class with common functionality to share same Redfish related functionaly in the 'redfish-gen' tool. End-User-Impact: None: (Code optimization without change functionality) Signed-off-by: Sergey Gulyaev <[email protected]>
serge4k
force-pushed
the
feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem
branch
from
February 27, 2023 09:46
86166fc
to
61f29d6
Compare
Create common Redfish class with common functionality to share same Redfish related functionaly in the 'redfish-gen' tool. Part of BBMC-1462 End-User-Impact: None: (Code optimization without change functionality) Signed-off-by: Sergey Gulyaev <[email protected]>
Create common Redfish class with common functionality to share same Redfish related functionaly in the 'redfish-gen' tool. Part of BBMC-1462 End-User-Impact: None: (Code optimization without change functionality) Signed-off-by: Sergey Gulyaev <[email protected]>
serge4k
force-pushed
the
feature/vegman/BBMC-1462-Add-redfish-schemas-only-from-implementation-and-oem
branch
from
February 27, 2023 15:18
d05cb58
to
6dcedd2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented logic inside the "redfish-gen" tool to prepare schemas based on BMC implementation and Oem schemas necessary for the "Redfish Service Validator" tool.
Part of BBMC-1462
End-User-Impact: Low: (The BMC's redfish service may be validated
by the "Redfish Service Validator" tool)