Add functions to close sessions by privelegies #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nest1ing
suggested changes
Nov 29, 2022
ikmsk10
suggested changes
Nov 30, 2022
- Add functions support functions (protected)
to provide information about session owner,
and user privelegies
- Add function to get the session items, in
order to follow the DRY principle, because
session items are required several times
and repeating the same steps each time
makes the code less-readable
- Added functions to actually close session
by its ID and Type, but the new functions
did include checks on user privelegies so
that before closing a session we would be
able to check if the calling session is
allowed to close the requested session or
not
End-User-Impact: it is now possible to close
session by its id and type
using busctl, priveligies
being checked using the
caller session ID
Signed-off-by: Nikolay Chegodaev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-User-Impact: it is now possible to close
session by its id and type
using busctl, priveligies
being checked using the
caller session ID
Signed-off-by: Nikolay Chegodaev [email protected]