Skip to content

Commit

Permalink
apply review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
rifqiyan committed Apr 2, 2024
1 parent 16d9813 commit 1f17adb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions src/axolotl/utils/callbacks/vessl_.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,7 @@ def on_log(
logs: Dict[str, float],
**kwargs # pylint: disable=unused-argument
):
# is_world_process_zero: Whether or not this process is the global main process (when training in a
# distributed fashion on several machines, this is only going to be `True` for one process).
if state.is_world_process_zero:
vessl.log(logs, state.global_step)
5 changes: 3 additions & 2 deletions src/axolotl/utils/vessl_.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@


def setup_vessl_env_vars(cfg: DictDefault):
# VESSL_RUN_INITIAL_CONFIG is a variable that contain path to
# default credential inside a VESSL Run
# VESSL_RUN_INITIAL_CONFIG is a variable that contain path to default credential inside a VESSL Run.
# Currently there is no docs regarding this variable, but it exists inside the container.
# Ref: https://screen.yanolja.in/lrTGow4Pr8eXhAai.png
credential_path = os.environ.get("VESSL_RUN_INITIAL_CONFIG")
if credential_path and not cfg.vessl_credential_path:
cfg.vessl_credential_path = credential_path

0 comments on commit 1f17adb

Please sign in to comment.