Add a pass to normalize address spaces before lowering to standard ops. #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -694,6 +694,7 @@ async def run_flow(self): | |||
| if(opts.unified): | |||
| self.file_opt_with_addresses = os.path.join(self.tmpdirname, 'input_opt_with_addresses.mlir') | |||
| await self.do_call(progress_bar.task, ['aie-opt', '--aie-localize-locks', | |||
| '--aie-normalize-address-spaces', | |||
There was a problem hiding this comment.
Should this get removed from aie-opt-passes?
There was a problem hiding this comment.
Yes, but it was suggested that this has to run before conversion to standard based on an error with handle address space 2
There was a problem hiding this comment.
Thanks, After your patch, I went back and actually processed what Jeff had indicated.
There was a problem hiding this comment.
It doesn't make sense to me to run this pass twice... so I factored it out of aie_opt_passes
fifield
approved these changes
Dec 6, 2023
makslevental
force-pushed
the
set_normalize
branch
from
12bc4e4 to
e7b9708
Compare
This takes care of handling memrefs with address space '2'.
makslevental
force-pushed
the
set_normalize
branch
from
e7b9708 to
550b273
Compare
|
@stephenneuendorffer can I merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of handling memrefs with address space '2'.