Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable pylint - too much noise #828

Merged
merged 1 commit into from
Dec 5, 2023
Merged

disable pylint - too much noise #828

merged 1 commit into from
Dec 5, 2023

Conversation

makslevental
Copy link
Contributor

No description provided.

@makslevental makslevental enabled auto-merge (squash) December 5, 2023 02:32
@makslevental makslevental merged commit 65cd872 into main Dec 5, 2023
7 checks passed
keryell
keryell reviewed Dec 5, 2023
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you did the great work, you could have just left it but just add a global condition to disable it. Of course there is a risk o bit-rotting if it is never used.

@makslevental
Copy link
Contributor Author

It's in the commit history (that's my philosophy on commented out dead code vs. removing) and I do plan restore it as soon I can reduce the barrage.

@makslevental makslevental deleted the disable_pylint branch December 5, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makslevental @keryell