Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn compiler warnings back on (and make some of them them Werror) #822

Merged
merged 3 commits into from
Dec 4, 2023
Merged

turn compiler warnings back on (and make some of them them Werror) #822

merged 3 commits into from
Dec 4, 2023

Conversation

makslevental
Copy link
Contributor

@makslevental makslevental commented Dec 3, 2023 •
edited
Loading

I had -DLLVM_ENABLE_WARNINGS=OFF accidentally in the mlir-wheels (which are now live).

@makslevental makslevental force-pushed the werror_return_type branch 5 times, most recently from 2593c29 to ebbc0a5 Compare December 3, 2023 10:05
@makslevental makslevental changed the title turn on -Werror=return-type turn compiler warnings back on (and make some of them them Werror) Dec 3, 2023
@makslevental makslevental requested a review from jsetoain December 4, 2023 15:21
@makslevental makslevental merged commit eb9b9b7 into main Dec 4, 2023
7 checks passed
@makslevental makslevental deleted the werror_return_type branch December 4, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsetoain jsetoain Awaiting requested review from jsetoain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@makslevental