Comprehensive linting and formatting #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
makslevental
force-pushed
the
fix_clang_tidy
branch
2 times, most recently
from
d7484b0 to
fabd563
Compare
Coverage ReportCreated: 2023-12-04 22:11Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 14.0.0 |
makslevental
force-pushed
the
fix_clang_tidy
branch
2 times, most recently
from
587e4b0 to
7460399
Compare
makslevental
changed the title
makslevental
force-pushed
the
fix_clang_tidy
branch
5 times, most recently
from
d4b63fb to
a924aba
Compare
makslevental
force-pushed
the
fix_clang_tidy
branch
2 times, most recently
from
8d9aa2f to
54046fa
Compare
makslevental
force-pushed
the
fix_clang_tidy
branch
4 times, most recently
from
51dc285 to
b0f195e
Compare
makslevental
force-pushed
the
fix_clang_tidy
branch
from
b0f195e to
b23b1b9
Compare
jsetoain
reviewed
Dec 2, 2023
makslevental
force-pushed
the
fix_clang_tidy
branch
from
b23b1b9 to
775b1c3
Compare
makslevental
force-pushed
the
fix_clang_tidy
branch
from
775b1c3 to
1315250
Compare
stephenneuendorffer
approved these changes
Dec 4, 2023
makslevental
force-pushed
the
fix_clang_tidy
branch
4 times, most recently
from
115d31a to
96141eb
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
makslevental
force-pushed
the
fix_clang_tidy
branch
from
96141eb to
b7fcb8b
Compare
| @@ -53,13 +53,13 @@ def infer_mlir_type( | |||
| if isinstance(py_val, bool): | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
| @@ -53,13 +53,13 @@ def infer_mlir_type( | |||
| if isinstance(py_val, bool): | |||
| return T.bool() | |||
| elif isinstance(py_val, int): | |||
| if -(2 ** 31) <= py_val < 2 ** 31: | |||
| if -(2**31) <= py_val < 2**31: | |||
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements "comprehensive" linting and formatting for both Python and C/C++. It runs
blackandpylintfor Python;clang-formatandclang-tidyfor C/C++.Notes:
Files changedtab.This PR itself serves as a test; I made "anti-changes" to
lib/Conversion/AIEVecToLLVM/AIEVecToLLVM.cppandpython/util.pyto exercise the formatters and linters. Thus (hopefully), this PR doesn't accurately represent the typical amount of noise the linters introduce.Note: I do not intend to "own" this code. This is a shared resource and should be shared responsibility.