Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for --assign-lock-ids pass #772

Merged
merged 9 commits into from
Dec 5, 2023

Conversation

newling
Copy link
Collaborator

@newling newling commented Nov 21, 2023

This fixes a few issues with this pass. The issues were

  1. hard coded number of locks per tile at 15.
  2. in some cases, locks were still being assigned IDs greater than the number of HW locks
  3. did not signal failure (just emitted error from op, and returned) to halt pass pipeline

This PR also implements the pass a bit more efficiently (does less work to find a free ID).

Copy link
Collaborator

@stephenneuendorffer stephenneuendorffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

lib/Dialect/AIE/Transforms/AIEAssignLockIDs.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignLockIDs.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignLockIDs.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignLockIDs.cpp Outdated Show resolved Hide resolved
lib/Dialect/AIE/Transforms/AIEAssignLockIDs.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@stephenneuendorffer stephenneuendorffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lib/Dialect/AIE/Transforms/AIEAssignLockIDs.cpp Outdated Show resolved Hide resolved
@makslevental
Copy link
Contributor

@newling is this good to go?

@newling
Copy link
Collaborator Author

newling commented Dec 5, 2023

@newling is this good to go?

I hope to merge today, got some other things to do first though. Thanks for the comments -- will address.

@newling newling force-pushed the fixes_assign_locks branch from 66c5b4d to eace15c Compare December 5, 2023 21:00
@newling
Copy link
Collaborator Author

newling commented Dec 5, 2023

@makslevental and @stephenneuendorffer I don't seem to have write permission -- I'm happy with the current state if you want to go ahead and merge this.

@makslevental makslevental merged commit 01aba90 into Xilinx:main Dec 5, 2023
7 checks passed
@makslevental
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants