-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for --assign-lock-ids pass #772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
7236e71
to
d4302d9
Compare
22d8f60
to
fe1519e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
21c3946
to
66c5b4d
Compare
@newling is this good to go? |
I hope to merge today, got some other things to do first though. Thanks for the comments -- will address. |
…re too many lock ops in a tile
66c5b4d
to
eace15c
Compare
@makslevental and @stephenneuendorffer I don't seem to have write permission -- I'm happy with the current state if you want to go ahead and merge this. |
Done! |
This fixes a few issues with this pass. The issues were
This PR also implements the pass a bit more efficiently (does less work to find a free ID).