New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize dynamic objectFifo #1934

Merged

pvasireddy-amd merged 4 commits into main from optimize_modulo

Dec 9, 2024

Collaborator

pvasireddy-amd commented Nov 19, 2024 •

edited

Loading

Using add-compare-subtract alternative to replace modulo operation in dynamic objectFifo lowering.

Contributor

github-actions bot commented Nov 19, 2024 •

edited

Loading

Coverage Report

Created: 2024-12-09 21:41

Click here for information about interpreting this report.

Filename	Function Coverage	Line Coverage	Region Coverage	Branch Coverage
home/runner/work/mlir-aie/mlir-aie/lib/Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp	100.00%	93.51%	90.11%	84.84%
Totals	100.00%	93.51%	90.11%	84.84%

Generated by llvm-cov -- llvm version 14.0.0

pvasireddy-amd marked this pull request as ready for review

November 20, 2024 03:46

pvasireddy-amd requested review from AndraBisca, stephenneuendorffer and fifield as code owners

November 20, 2024 03:46

pvasireddy-amd changed the title ~~[TEST] Optimize dynamic objectFifo for ping-pong buffers~~ Optimize dynamic objectFifo for ping-pong buffers

pvasireddy-amd requested a review from jgmelber

November 20, 2024 17:55

pvasireddy-amd requested a review from denolf as a code owner

November 21, 2024 00:27

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

clang-format

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 220 in e9a54f7

    
           return XAie_LockAcquire(&(ctx->DevInst), XAie_TileLoc(0,0), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 222 in e9a54f7

    
           int mlir_aie_release_out_cons_cons_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 224 in e9a54f7

    
           return XAie_LockRelease(&(ctx->DevInst), XAie_TileLoc(0,0), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 226 in e9a54f7

    
           int mlir_aie_acquire_out_prod_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 228 in e9a54f7

    
           return XAie_LockAcquire(&(ctx->DevInst), XAie_TileLoc(0,2), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 230 in e9a54f7

    
           int mlir_aie_release_out_prod_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 232 in e9a54f7

    
           return XAie_LockRelease(&(ctx->DevInst), XAie_TileLoc(0,2), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 234 in e9a54f7

    
           int mlir_aie_acquire_out_cons_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 236 in e9a54f7

    
           return XAie_LockAcquire(&(ctx->DevInst), XAie_TileLoc(0,2), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 238 in e9a54f7

    
           int mlir_aie_release_out_cons_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 240 in e9a54f7

    
           return XAie_LockRelease(&(ctx->DevInst), XAie_TileLoc(0,2), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 242 in e9a54f7

    
           int mlir_aie_acquire_in_cons_prod_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 244 in e9a54f7

    
           return XAie_LockAcquire(&(ctx->DevInst), XAie_TileLoc(0,2), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 246 in e9a54f7

    
           int mlir_aie_release_in_cons_prod_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 248 in e9a54f7

    
           return XAie_LockRelease(&(ctx->DevInst), XAie_TileLoc(0,2), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 250 in e9a54f7

    
           int mlir_aie_acquire_in_cons_cons_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 252 in e9a54f7

    
           return XAie_LockAcquire(&(ctx->DevInst), XAie_TileLoc(0,2), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 254 in e9a54f7

    
           int mlir_aie_release_in_cons_cons_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 256 in e9a54f7

    
           return XAie_LockRelease(&(ctx->DevInst), XAie_TileLoc(0,2), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 258 in e9a54f7

    
           int mlir_aie_acquire_in_prod_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 260 in e9a54f7

    
           return XAie_LockAcquire(&(ctx->DevInst), XAie_TileLoc(0,0), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 262 in e9a54f7

    
           int mlir_aie_release_in_prod_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 264 in e9a54f7

    
           return XAie_LockRelease(&(ctx->DevInst), XAie_TileLoc(0,0), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 266 in e9a54f7

    
           int mlir_aie_acquire_in_cons_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 268 in e9a54f7

    
           return XAie_LockAcquire(&(ctx->DevInst), XAie_TileLoc(0,0), XAie_LockInit(id,value), timeout);

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 270 in e9a54f7

    
           int mlir_aie_release_in_cons_lock(aie_libxaie_ctx_t* ctx, int value, int timeout) {

[clang-format] _{reported by reviewdog 🐶}

mlir-aie/programming_examples/dyn_objFifo/sliding_window/build/aie.mlir.prj/aie_inc.cpp

Line 272 in e9a54f7

    
           return XAie_LockRelease(&(ctx->DevInst), XAie_TileLoc(0,0), XAie_LockInit(id,value), timeout);

pvasireddy-amd requested a review from jackl-xilinx as a code owner

November 21, 2024 16:56

fifield reviewed

View reviewed changes

programming_examples/dyn_objFifo/nested_loops/aie2.py Outdated Show resolved Hide resolved

programming_examples/dyn_objFifo/sliding_window/Makefile Outdated Show resolved Hide resolved

Collaborator

jgmelber commented Nov 22, 2024

Before merging please move the dynamic object fifo tests to tests/npu-xrt since they are not programming examples and remove the Makefiles

pvasireddy-amd marked this pull request as draft

December 5, 2024 23:09

pvasireddy-amd added 2 commits

December 6, 2024 16:44


          Add-compare alternative for modulo

0b3dc3a


          Merge branch 'main' of https://github.com/Xilinx/mlir-aie into alt

ffcc4e0

pvasireddy-amd force-pushed the optimize_modulo branch from 98fc01e to ffcc4e0 Compare

December 7, 2024 00:00


          Modified tests with the alt approach

c696867

pvasireddy-amd marked this pull request as ready for review

December 7, 2024 02:10

pvasireddy-amd changed the title ~~Optimize dynamic objectFifo for ping-pong buffers~~ Optimize dynamic objectFifo

AndraBisca approved these changes

View reviewed changes

Collaborator

AndraBisca left a comment

LGTM :)


          Merge branch 'main' into optimize_modulo

10cb10b

jgmelber approved these changes

View reviewed changes

pvasireddy-amd added this pull request to the merge queue

Merged via the queue into main with commit c7e37e9

53 checks passed

pvasireddy-amd deleted the optimize_modulo branch

December 9, 2024 22:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

fifield fifield left review comments

AndraBisca AndraBisca approved these changes

jgmelber jgmelber approved these changes

stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer is a code owner

denolf Awaiting requested review from denolf

jackl-xilinx Awaiting requested review from jackl-xilinx

Labels

None yet