Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASPLOS] Passthrough Kernel README and test.py #1262

Merged
merged 26 commits into from
Apr 17, 2024
Merged

Conversation

jgmelber
Copy link
Collaborator

No description provided.

@jgmelber jgmelber changed the title [ASPLOS] Programming Example READMEs [ASPLOS] Passthrough Kernel README and test.py Apr 16, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jgmelber jgmelber marked this pull request as ready for review April 16, 2024 17:46
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Coverage Report

Created: 2024-04-17 04:56

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
Conversion/AIEVecToLLVM/AIEVecToLLVM.cpp 82.05% 87.48% 74.30% 60.16%
Dialect/AIE/Transforms/AIEObjectFifoRegisterProcess.cpp 100.00% 93.63% 96.77% 90.74%
Dialect/AIE/Transforms/AIEObjectFifoStatefulTransform.cpp 100.00% 95.66% 94.44% 89.50%
Dialect/AIEVec/TransformOps/AIEVecTransformOps.cpp 100.00% 98.44% 95.77% 76.92%
Dialect/AIEVec/Transforms/VectorToAIEVecConversions.cpp 70.87% 63.72% 49.70% 41.68%
Dialect/AIEX/IR/AIEXDialect.cpp 100.00% 85.09% 84.44% 75.00%
Dialect/AIEX/Transforms/AIEDmaToIpu.cpp 100.00% 93.21% 88.75% 76.79%
Dialect/AIEX/Transforms/AIEXToStandard.cpp 75.00% 75.00% 66.67% 50.00%
Totals 81.71% 78.53% 65.98% 58.23%
Generated by llvm-cov -- llvm version 14.0.0

Copy link
Collaborator

@denolf denolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some improvement proposals

programming_examples/basic/passthrough_kernel/run.lit Outdated Show resolved Hide resolved
programming_examples/basic/passthrough_kernel/README.md Outdated Show resolved Hide resolved
programming_examples/basic/passthrough_kernel/test.py Outdated Show resolved Hide resolved
programming_examples/basic/passthrough_kernel/README.md Outdated Show resolved Hide resolved
jgmelber and others added 3 commits April 16, 2024 15:47
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
programming_examples/basic/passthrough_kernel/aie2.py Outdated Show resolved Hide resolved
programming_examples/ml/vector_softmax/aie2.py Outdated Show resolved Hide resolved
python/utils/trace.py Show resolved Hide resolved
python/utils/trace.py Show resolved Hide resolved
python/utils/trace.py Show resolved Hide resolved
python/utils/trace.py Show resolved Hide resolved
python/utils/trace.py Show resolved Hide resolved
row=int(shim.row),
address=0x1D204 if channel == 0 else 0x1D20C,
value=bd_id,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[black] reported by reviewdog 🐶

Suggested change
)
)

jackl-xilinx and others added 3 commits April 16, 2024 21:18
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jackl-xilinx jackl-xilinx merged commit 3238748 into asplos Apr 17, 2024
53 of 54 checks passed
@jackl-xilinx jackl-xilinx deleted the asplos-jgm-readmes branch April 17, 2024 05:26
@jackl-xilinx jackl-xilinx mentioned this pull request Apr 17, 2024
fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 17, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kristof Denolf <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
fifield pushed a commit that referenced this pull request Apr 17, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kristof Denolf <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
singagan pushed a commit that referenced this pull request Apr 18, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kristof Denolf <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
fifield pushed a commit to fifield/mlir-aie that referenced this pull request Apr 22, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kristof Denolf <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants