Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unsecure loading when loading xclbin files #1213

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

stephenneuendorffer
Copy link
Collaborator

This avoids the need to be root when running designs.

Copy link
Contributor

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please just delete absolutely everything in run_on_ipu.sh except for that export

@stephenneuendorffer
Copy link
Collaborator Author

Baby steps I think... this will help the immediate CI situation, so that's my main goal at the moment.

@jgmelber
Copy link
Collaborator

Should we just all move to linux 6.8-rc2 and xdna-driver@37961e1

@makslevental
Copy link
Contributor

Should we just all move to linux 6.8-rc2 and xdna-driver@37961e1

There is no "we" - there will always be multiple versions of the driver floating around that we don't control/own. Best practices actually dictates we have multiple versions of the driver (a sliding window around some "lowest common denominator") always being tested but 🤷 .

@jgmelber
Copy link
Collaborator

Should we just all move to linux 6.8-rc2 and xdna-driver@37961e1

There is no "we" - there will always be multiple versions of the driver floating around that we don't control/own. Best practices actually dictates we have multiple versions of the driver (a sliding window around some "lowest common denominator") always being tested but 🤷 .

"we" meaning the repo requiring a certain version, if someone wants something else, well we can't guarantee it works

@makslevental
Copy link
Contributor

makslevental commented Apr 10, 2024

Should we just...

The answer is no.

@jgmelber
Copy link
Collaborator

Should we just...

The answer is no.

Internal dev and CI will be updating to the latest

@stephenneuendorffer
Copy link
Collaborator Author

Internal dev and CI will be updating to the latest

@jgmelber, please clarify, since I got a different answer the other day.

  1. What version do you expect to run at ASPLOS?
  2. What versions do we intend to CI (assuming this includes 1)
  3. What versions do we expect to work (assuming this includes 2)

@jgmelber
Copy link
Collaborator

Internal dev and CI will be updating to the latest

@jgmelber, please clarify, since I got a different answer the other day.

  1. What version do you expect to run at ASPLOS?

  2. What versions do we intend to CI (assuming this includes 1)

  3. What versions do we expect to work (assuming this includes 2)

You're right this is the opposite answer from before but after that discussion I built and verified the latest kernel and xdna-driver.

I'm using linux 6.8-rc2 and xdna-driver@37961e1 for ASPLOS. I'm planning to update the dev mini PCs once the demo PCs are done. @fifield discussed updating the CI.

stephenneuendorffer and others added 3 commits April 10, 2024 16:08
This avoids the need to be root when running designs.
This will offload the existing amd7940hs runners.
@makslevental makslevental merged commit c1ec412 into Xilinx:main Apr 10, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants