Add issue_token attribute to IpuDmaMemcpyNdOp
#1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm curious - when do you want to do this? |
|
The test fails are flakes (something about caching the ccache dir) |
If you have a sequence of bd writes using the same bd_id, to avoid overwriting a bd before fully executed. |
Makes sense |
|
@makslevental Could you help with approving the workflow again? |
Sure but I pinged you on slack about a longer-term solution... |
stephenneuendorffer
previously requested changes
Apr 10, 2024
makslevental
force-pushed
the
ipu-dma-add-issue-token
branch
from
e1e2aa8 to
f82e475
Compare
makslevental
dismissed
stephenneuendorffer’s stale review
addressed with updated doc
makslevental
force-pushed
the
ipu-dma-add-issue-token
branch
from
0f8b591 to
22289fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
issue_tokenfield toIpuDmaMemcpyNdOp. This allows more fine-grained control of which DMA operations should issue tokens and enables synchronization on MM2S DMA operations in addition to the S2MM DMA operations which were implicitly enabled earlier. The newissue_tokenfield is set tofalseby default for backward compatibility with the implicit issuance of tokens for S2MM DMA operations only.cc @fifield @jgmelber @AndraBisca Could you help review?