Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASPLOS] merge main into asplos #1170

Merged
merged 36 commits into from
Apr 4, 2024
Merged

[ASPLOS] merge main into asplos #1170

merged 36 commits into from
Apr 4, 2024

Conversation

jgmelber
Copy link
Collaborator

@jgmelber jgmelber commented Apr 4, 2024

No description provided.

jsetoain and others added 30 commits March 8, 2024 11:45
@jsetoain
[aievec] Remove unused build targets (#1113)
f7ea6fb
@newling
Bump required cmake (3.21 -> 3.23) to get OpenSSL::applink fix (#1095)
3cea58b
@makslevental
bump llvm (#1117)
064e2a2
@jgmelber
Update quick_setup.sh to fix vanishing mlir_aie wheel (#1119)
dda882a
@Abhishek-Varma @erwei-xilinx
[AMD-AIE] Build microkernels for AMD-AIE (#1109)
50cfa7c 
Signed-off-by: Abhishek Varma <[email protected]>
Co-authored-by: erwei-xilinx <[email protected]>
@jgmelber
Small fixes to matmul array (#1122)
34f96fc
@AndraBisca @jackl-xilinx @abisca
Add keep_pkt_header OptionalAttr to PacketFlowOp (#1121)
2cfb226 
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: AndraBisca <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
@andrej
Matmul sweep (#1056)
90397ad
@erieaton-amd
Fixes for aie2xclbin on Windows (#1129)
fed78cd 
This deals with some issues that appear when you try to run the windows build of aie2xclbin. Some of these are workarounds for problems with the peano build on windows that ought to get removed later.
@jgmelber @github-actions
Add sweep plot mode (#1132)
6e0811e 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jgmelber
Fix matmul average calculation (#1133)
e0514b1
@makslevental
offset, len, and stride in words not bytes (or 32b) (#1111)
1fb02e8
@keryell
Add LSP protocol server for AIE dialects (#1112)
19d9a96 
This allows semantical features such as type information, auto-completion, etc. to IDE and editors using LSP.
See mlir.llvm.org/docs/Tools/MLIRLSP for use case.

To be used for example with Emacs:

;; Enable MLIR mode
(require 'mlir-mode)
;; Prepare MLIR LSP mode
(load-file ".../llvm/mlir/utils/emacs/mlir-lsp-client.el")
(lsp-mlir-setup)
;; Think about customizing lsp-mlir-server-executable to use the server
;; with its own dialects.
; '(lsp-mlir-server-executable ".../mlir-aie/build/bin/aie-lsp-server")
;; Use lsp-mode in mlir-mode
(add-hook 'mlir-mode-hook 'lsp)
@jackl-xilinx
Update tutorial README (#1141)
6ca54d5
@keryell
Adapt LIT test configuration to new RyzenAI device name
dd72841 
Starting with Linux 6.8 the format of the device returned by "xbutil examine"
is like "[0000:66:00.1] : RyzenAI-npu1"
@keryell
4 space indentation in Python source files
2de4069
@jgmelber
[Quick Setup] Update script mlir-aie wheel (#1144)
816ba5e
@jgmelber
Update run.lit for verify (#1145)
208700e
@Abhishek-Varma
[AMD-AIE] Update the microkernel to be targeted by Pad-Pack pipeline (#…
5ef3076 
…1136)

Signed-off-by: Abhishek Varma <[email protected]>
@newling @jsetoain
Extend vectorization workaround to 8-bit types (#1149)
d233485 
Co-authored-by: Javier Setoain <[email protected]>
@AndraBisca @abisca
Fix printer of objectFifo consumerTiles (#1147)
1e4a49e 
Co-authored-by: AndraBisca <[email protected]>
@erwei-xilinx
Modify multi-col aie_partition.json (#1161)
11822b0
@fifield
Fix tests (#1162)
e317b6e 
misc test fixes, including some failing when chess is not the default compiler
@jamestcl-amd
[aievec] to-llvm flow for i8xi8, i16xi16, bf16xbf16 elementwise multi…
7f1b684 
…plication (#1139)

* Add mul/srs/broadcast/concat/ext/undef intrinsics to XLLVM. The op names would need a better naming convention since more intrinsics are going to be added to the XLLVM.
* Add aievec-to-llvm conversion pattern for the new intrinsics.
* Add a FoldAIECastOps pattern in AIEVecToLLVM pass. This pattern folds all the aievec.cast ops that are introduced in the vector->aievec pass. Taking this shortcut, we do not need to conditionally introduce aievec.cast ops in the vector->aievec conversion patterns.
* Add op folder to aievec.cast op, and remove the FoldAIECastOps pattern originally introduced in the AIEVecOptimizations pass.
* Add i8xi8_mul_elem, i8xi8_mul_elem_2, i16xi16_mul_elem, i16xi16_mul_elem_2, bf16xbf16_mul_elem, bf16xbf16_mul_elem_2 e2e tests for the to-llvm flow. This includes updating the testbench.cc and the test script. These tests, like other to-cpp tests, go through the simulator to verify the numeric correctness.
* Add aievec-to-llvm conversion tests for all the new XLLVM ops.
* Add target llvm translation tests.
@keryell
Remove some confusing trailing /
f14d9cf 
My editor removed by itself also a lot of trailing spaces.
@keryell
Accept also --verbose to be coherent with all other options
bad0efc
@keryell
Fix cross-compilation with Vitis 2023.2 and Ubuntu 23.10
5bba789 
The --sysroot configuration was not enough to find C++ standard library and
runtime.
@keryell
Fix tests to use up-to-date LIT configuration variables
7b6f798 
--sysroot=%VITIS_SYSROOT% has been replaced mostly with %VitisSysrootFlag%

Strangely, these tests may have been broken for almost 1 year now since
#422
which refactored the LIT configuration variables with
42d8076
@keryell
Handle new firmware location for RyzenAI and Linux 6.8
36df259
@keryell
Run the RyzenAI XRT test locally as root as a work-around
7932364
@jgmelber jgmelber merged commit aef1490 into asplos Apr 4, 2024
54 checks passed
@jgmelber jgmelber deleted the asplos-main branch April 4, 2024 16:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Coverage Report

Created: 2024-04-04 16:35

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
Totals- - - -
Generated by llvm-cov -- llvm version 14.0.0

fifield added a commit to fifield/mlir-aie that referenced this pull request Apr 9, 2024
@jgmelber @jsetoain
@newling @makslevental @Abhishek-Varma @erwei-xilinx @AndraBisca @jackl-xilinx @abisca @andrej @erieaton-amd @github-actions @keryell @fifield @jamestcl-amd
[ASPLOS] merge main into asplos (Xilinx#1170)
24eac0e 
Signed-off-by: Abhishek Varma <[email protected]>
Co-authored-by: Javier Setoain <[email protected]>
Co-authored-by: James Newling <[email protected]>
Co-authored-by: Maksim Levental <[email protected]>
Co-authored-by: Abhishek Varma <[email protected]>
Co-authored-by: erwei-xilinx <[email protected]>
Co-authored-by: Andra Bisca <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: AndraBisca <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: André Rösti <[email protected]>
Co-authored-by: erieaton-amd <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ronan Keryell <[email protected]>
Co-authored-by: Jeff Fifield <[email protected]>
Co-authored-by: James Lin <[email protected]>
fifield added a commit to fifield/mlir-aie that referenced this pull request Apr 9, 2024
@jgmelber @jsetoain
@newling @makslevental @Abhishek-Varma @erwei-xilinx @AndraBisca @jackl-xilinx @abisca @andrej @erieaton-amd @github-actions @keryell @fifield @jamestcl-amd
[ASPLOS] merge main into asplos (Xilinx#1170)
419f44a 
Signed-off-by: Abhishek Varma <[email protected]>
Co-authored-by: Javier Setoain <[email protected]>
Co-authored-by: James Newling <[email protected]>
Co-authored-by: Maksim Levental <[email protected]>
Co-authored-by: Abhishek Varma <[email protected]>
Co-authored-by: erwei-xilinx <[email protected]>
Co-authored-by: Andra Bisca <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: AndraBisca <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: André Rösti <[email protected]>
Co-authored-by: erieaton-amd <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ronan Keryell <[email protected]>
Co-authored-by: Jeff Fifield <[email protected]>
Co-authored-by: James Lin <[email protected]>
fifield added a commit to fifield/mlir-aie that referenced this pull request Apr 9, 2024
@jgmelber @jsetoain
@newling @makslevental @Abhishek-Varma @erwei-xilinx @AndraBisca @jackl-xilinx @abisca @andrej @erieaton-amd @github-actions @keryell @fifield @jamestcl-amd
[ASPLOS] merge main into asplos (Xilinx#1170)
64f18b8 
Signed-off-by: Abhishek Varma <[email protected]>
Co-authored-by: Javier Setoain <[email protected]>
Co-authored-by: James Newling <[email protected]>
Co-authored-by: Maksim Levental <[email protected]>
Co-authored-by: Abhishek Varma <[email protected]>
Co-authored-by: erwei-xilinx <[email protected]>
Co-authored-by: Andra Bisca <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: AndraBisca <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: André Rösti <[email protected]>
Co-authored-by: erieaton-amd <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ronan Keryell <[email protected]>
Co-authored-by: Jeff Fifield <[email protected]>
Co-authored-by: James Lin <[email protected]>
fifield added a commit to fifield/mlir-aie that referenced this pull request Apr 9, 2024
@jgmelber @jsetoain
@newling @makslevental @Abhishek-Varma @erwei-xilinx @AndraBisca @jackl-xilinx @abisca @andrej @erieaton-amd @github-actions @keryell @fifield @jamestcl-amd
[ASPLOS] merge main into asplos (Xilinx#1170)
89830cc 
Signed-off-by: Abhishek Varma <[email protected]>
Co-authored-by: Javier Setoain <[email protected]>
Co-authored-by: James Newling <[email protected]>
Co-authored-by: Maksim Levental <[email protected]>
Co-authored-by: Abhishek Varma <[email protected]>
Co-authored-by: erwei-xilinx <[email protected]>
Co-authored-by: Andra Bisca <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: AndraBisca <[email protected]>
Co-authored-by: Jack Lo <[email protected]>
Co-authored-by: André Rösti <[email protected]>
Co-authored-by: erieaton-amd <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ronan Keryell <[email protected]>
Co-authored-by: Jeff Fifield <[email protected]>
Co-authored-by: James Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndraBisca AndraBisca AndraBisca approved these changes

@jackl-xilinx jackl-xilinx Awaiting requested review from jackl-xilinx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.