fix(date-picker): 修复format传入函数，只有在type='weekrange'下生效 #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyprepare
reviewed
May 15, 2024
| @@ -68,6 +68,10 @@ const Input = ({ | |||
| vals = vals?.toLocaleUpperCase() | |||
| } | |||
|
|
|||
| if (typeof format === 'function' && date) { | |||
There was a problem hiding this comment.
建议将此处理移到第 41 行的上面，直接在该逻辑中更新 value，然后直接 return 不往下执行，这样可以减少不必要的代码执行
zyprepare
reviewed
May 16, 2024
| @@ -38,6 +38,12 @@ const Input = ({ | |||
| const [value, setValue] = useState<string | null>('') | |||
|
|
|||
| useEffect(() => { | |||
| if (typeof format === 'function' && date) { | |||
| setValue(format(date)) | |||
| cacheValues.current = format(date) | |||
There was a problem hiding this comment.
建议 43 行移到 42 行上面，然后直接 setValue(cacheValues.current)
zyprepare
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #2825