Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move web page to html #627

Merged
merged 11 commits into from
Jan 14, 2025
Merged

Conversation

chemwolf6922
Copy link
Contributor

@chemwolf6922 chemwolf6922 commented Jan 11, 2025

Why is this change made

Putting the webpage inside a string is not ideal for maintenance.

Changes

  • Move the web page to a html file.
  • Translate using miot i18n.

Tests

Tested login in my local environment.

@topsworld topsworld changed the title Move web page to html feat: move web page to html Jan 13, 2025
@topsworld topsworld added the enhancement New feature or request label Jan 13, 2025
@topsworld topsworld requested a review from SusanPhevos January 13, 2025 09:38
@topsworld topsworld requested a review from JimmyKmi January 13, 2025 14:20
Copy link
Contributor

@topsworld topsworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed in my develop machine.

@topsworld topsworld merged commit 2881948 into XiaoMi:main Jan 14, 2025
5 checks passed
@SusanPhevos
Copy link
Contributor

@chemwolf6922
Dear contributor,
Thanks for your contribution to ha_xiaomi_home. When you submitted your pull request, the Contributor License Agreement (CLA) of ha_xiaomi_home was not ready. We sincerely hope that you sign the CLA to ensure that all of your past and future contributions to ha_xiaomi_home are legally authorized.
Please view the CLA at https://cla-assistant.io/xiaomi/ha_xiaomi_home and click "Sign in with GitHub to agree" button to sign it.
Thanks again for your support!
ha_xiaomi_home Team

尊敬的开发者:
感谢您对 ha_xiaomi_home 开源项目的宝贵贡献!鉴于您提交 PR 时,项目的贡献者许可协议(Contributor License Agreement,CLA)尚未完善,我们希望您补签 CLA ,以确保您过往及未来对该项目的所有贡献均能被合法授权。
具体操作:请您在 https://cla-assistant.io/xiaomi/ha_xiaomi_home 中阅读 CLA 并点击“Sign in with GitHub to agree”按钮以签署协议。
再次感谢您的支持!
ha_xiaomi_home 团队

@chemwolf6922
Copy link
Contributor Author

@chemwolf6922 Dear contributor, Thanks for your contribution to ha_xiaomi_home. When you submitted your pull request, the Contributor License Agreement (CLA) of ha_xiaomi_home was not ready. We sincerely hope that you sign the CLA to ensure that all of your past and future contributions to ha_xiaomi_home are legally authorized. Please view the CLA at https://cla-assistant.io/xiaomi/ha_xiaomi_home and click "Sign in with GitHub to agree" button to sign it. Thanks again for your support! ha_xiaomi_home Team

尊敬的开发者: 感谢您对 ha_xiaomi_home 开源项目的宝贵贡献!鉴于您提交 PR 时,项目的贡献者许可协议(Contributor License Agreement,CLA)尚未完善,我们希望您补签 CLA ,以确保您过往及未来对该项目的所有贡献均能被合法授权。 具体操作:请您在 https://cla-assistant.io/xiaomi/ha_xiaomi_home 中阅读 CLA 并点击“Sign in with GitHub to agree”按钮以签署协议。 再次感谢您的支持! ha_xiaomi_home 团队

目前的CLA没有说明以下问题,我拒绝签署,请加以完善:

  1. 请明确说明贡献者能和不能对“贡献”进行的操作,例如在什么情况下构成对小米的侵权。
  2. 请说明社区贡献者的贡献将如何被体现。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants