Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter miwifi.* devices #564

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

topsworld
Copy link
Contributor

Why?

All devices with did starting with "miwifi." are routers that interface between the Xiaomi home cloud and the Xiaomi router cloud. These routers have all defined functions but have not been implemented, so they are all filtered out; some routers that are not "miwifi.*" also have this problem.

Changed

Filter the devices whose did starts with "miwifi".

After the update, it is necessary to enter the integrated instance: Configuration > Update Device Information, and delete the unavailable devices.

@topsworld topsworld self-assigned this Jan 3, 2025
@topsworld topsworld added the enhancement New feature or request label Jan 3, 2025
@topsworld topsworld marked this pull request as ready for review January 3, 2025 14:45
Copy link
Contributor

@SusanPhevos SusanPhevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec_filter.json shall add

    "urn:miot-spec-v2:device:router:0000A036:xiaomi-rd03": {
        "services": [
            "*"
        ]
    }

to filter out xiaomi.router.rd03 which is not implemented complying MIoT-Spec-V2.

@topsworld
Copy link
Contributor Author

spec_filter.json shall add

    "urn:miot-spec-v2:device:router:0000A036:xiaomi-rd03": {
        "services": [
            "*"
        ]
    }

to filter out xiaomi.router.rd03 which is not implemented complying MIoT-Spec-V2.

The device information has been directly filtered, and there is no need to filter the specs one by one any longer.

@SusanPhevos
Copy link
Contributor

spec_filter.json shall add

    "urn:miot-spec-v2:device:router:0000A036:xiaomi-rd03": {
        "services": [
            "*"
        ]
    }

to filter out xiaomi.router.rd03 which is not implemented complying MIoT-Spec-V2.

The device information has been directly filtered, and there is no need to filter the specs one by one any longer.

The did of xiaomi.router.rd03 does not begin with "miwifi.".

@topsworld topsworld requested a review from SusanPhevos January 6, 2025 06:41
@topsworld topsworld merged commit 0566546 into XiaoMi:main Jan 7, 2025
5 checks passed
@topsworld topsworld deleted the feat-filter-miwifi-devices branch January 7, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

小米路由器AX3000T问题 [Bug]: xiaomi.router.rd03设备无法读取
2 participants