feat: Use aiohttp instead of waiting for blocking calls #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The nl translation does not have a entry in the list. Causing the test to fail. |
|
Please use squash merge on this one. The commit history is really messy. |
chemwolf6922
changed the title
topsworld
approved these changes
Dec 20, 2024
SusanPhevos
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change made
The original http requests in
miot_cloud.pyuse a async wrapper around a blocking call. Which will spawn a new thread for each http call.Changes
aiohttpinstead.aiohttpas a dependency.Tests
Tested with my local setup. Tested adding device & controlling device through cloud.