New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the install logic #212

Merged

SusanPhevos merged 1 commit into XiaoMi:main from chemwolf6922:patch-1

Dec 19, 2024

Contributor

chemwolf6922 commented Dec 19, 2024

Why is this change made

The old install logic uses a if logic to handle missing root conditions. Which is not straightforward and unnecessary.

Changes

Avoid switching directories.
Use variables to avoid repeating path names.
Use mkdir -p instead to make sure the target root is created.

Tests

Tested the script with local folders.


          Simplify the install logic.

3c464a0

SusanPhevos approved these changes

View reviewed changes

SusanPhevos merged commit c4a981a into XiaoMi:main

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet