fix: add water heater on_off feature

XiaoMi · Jan 7, 2025 · 84e79c3 · 84e79c3
1 parent 56e9f1d
commit 84e79c3
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/custom_components/xiaomi_home/water_heater.py b/custom_components/xiaomi_home/water_heater.py
@@ -102,7 +102,6 @@ def __init__(
         super().__init__(miot_device=miot_device, entity_data=entity_data)
         self._attr_temperature_unit = None
         self._attr_supported_features = WaterHeaterEntityFeature(0)
-        self._attr_operation_list = None
         self._prop_on = None
         self._prop_temp = None
         self._prop_target_temp = None
@@ -114,6 +113,8 @@ def __init__(
             # on
             if prop.name == 'on':
                 self._prop_on = prop
+                self._attr_supported_features |= (
+                    WaterHeaterEntityFeature.ON_OFF)
             # temperature
             if prop.name == 'temperature':
                 if isinstance(prop.value_range, dict):
@@ -153,10 +154,8 @@ def __init__(
                 self._attr_supported_features |= (
                     WaterHeaterEntityFeature.OPERATION_MODE)
                 self._prop_mode = prop
-        if self._attr_operation_list is None:
+        if not self._attr_operation_list:
             self._attr_operation_list = [STATE_ON]
-        else:
-            self._attr_operation_list.append(STATE_ON)
         self._attr_operation_list.append(STATE_OFF)
 
     async def async_turn_on(self) -> None: