refactor: Accept Grammar by ref during codegen

It's more idiomatic to use implicit Deref and accept arguments by-ref if we do not need to know about the specific container/wrapper they're in.
Xanewok · Nov 15, 2023 · d059486 · d059486
1 parent 7f9215b
commit d059486
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/crates/codegen/parser/generator/src/code_generator.rs b/crates/codegen/parser/generator/src/code_generator.rs
@@ -2,7 +2,6 @@ use std::{
     collections::{BTreeMap, BTreeSet},
     mem,
     path::PathBuf,
-    rc::Rc,
 };
 
 use anyhow::Result;
@@ -58,7 +57,7 @@ struct ScannerContext {
 }
 
 impl CodeGenerator {
-    pub fn write_source(output_dir: &PathBuf, grammar: Rc<Grammar>) -> Result<()> {
+    pub fn write_source(output_dir: &PathBuf, grammar: &Grammar) -> Result<()> {
         let mut code = Self::default();
         grammar.accept_visitor(&mut code);
         let code = &code;

diff --git a/crates/solidity/outputs/cargo/build/src/main.rs b/crates/solidity/outputs/cargo/build/src/main.rs
@@ -20,7 +20,7 @@ fn main() -> Result<()> {
         let grammar = Grammar::from_dsl_v1();
         let crate_dir = CargoWorkspace::locate_source_crate("slang_solidity")?;
 
-        CodeGenerator::write_source(&crate_dir.join("src/generated"), grammar)?;
+        CodeGenerator::write_source(&crate_dir.join("src/generated"), &grammar)?;
     }
 
     // This build script is not directly depended on by the caller source crate, so we need to manually

diff --git a/crates/solidity/outputs/npm/build/src/main.rs b/crates/solidity/outputs/npm/build/src/main.rs
@@ -20,7 +20,7 @@ fn main() -> Result<()> {
         let grammar = Grammar::from_dsl_v1();
         let crate_dir = CargoWorkspace::locate_source_crate("solidity_npm_crate")?;
 
-        CodeGenerator::write_source(&crate_dir.join("src/generated"), grammar)?;
+        CodeGenerator::write_source(&crate_dir.join("src/generated"), &grammar)?;
     }
 
     // This build script is not directly depended on by the caller source crate, so we need to manually