Warn against and fix meta_variable_misuse

Xanewok · Dec 12, 2023 · 9f6733e · 9f6733e
1 parent c721b9f
commit 9f6733e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/.cargo/config.toml b/.cargo/config.toml
@@ -13,6 +13,7 @@ rustflags = [
 	"-Wunused_crate_dependencies",
 	"-Wunused_lifetimes",
 	"-Wunused_tuple_struct_fields", # Will be uplifed into `dead_code` (warn-by-default) with https://github.com/rust-lang/rust/pull/118297
+	"-Wmeta_variable_misuse",
 	# Rust 2018 idioms that are not yet warn-by-default:
 	"-Welided_lifetimes_in_paths",
 	"-Wunused_extern_crates",

diff --git a/crates/codegen/parser/runtime/src/support/scanner_macros.rs b/crates/codegen/parser/runtime/src/support/scanner_macros.rs
@@ -1,7 +1,7 @@
 #[allow(unused_macros)]
 macro_rules! scan_chars {
     ($stream:ident, $($char:literal),+) => {
-        if $( $stream.next() == Some($char) )&&* {
+        if $( $stream.next() == Some($char) )&&+ {
             true
         } else {
             $stream.undo();
@@ -14,7 +14,7 @@ macro_rules! scan_chars {
 macro_rules! scan_none_of {
     ($stream:ident, $($char:literal),+) => {
         if let Some(c) = $stream.next() {
-            if $(c != $char)&&* {
+            if $(c != $char)&&+ {
                 true
             } else {
                 $stream.undo();

diff --git a/crates/solidity/outputs/cargo/crate/src/generated/support/scanner_macros.rs b/crates/solidity/outputs/cargo/crate/src/generated/support/scanner_macros.rs
diff --git a/crates/solidity/outputs/npm/crate/src/generated/support/scanner_macros.rs b/crates/solidity/outputs/npm/crate/src/generated/support/scanner_macros.rs