Warn against implicit_clone again

Cargo.toml

@@ -142,7 +142,6 @@ rest_pat_in_fully_bound_structs = "warn" # Prefer not to use `..` in fully bound
 verbose_file_reads = "warn"              # Prefer simpler and more concise `fs::read_to_string`
 # # Pedantic
 pedantic = "warn"                                                      # Warn about pedantic lints, except...
-implicit_clone = { level = "allow", priority = 1 }                     # A lot of false positives, tuned down in Clippy bundled with Rust 1.73
 match_same_arms = { level = "allow", priority = 1 }                    # It's often clearer to have the same arm twice
 missing_errors_doc = { level = "allow", priority = 1 }                 # Most of our code is internal; let's not clutter the docs until...
 missing_panics_doc = { level = "allow", priority = 1 }                 # ... we care about the public documentation in our shipped crates

crates/codegen/language/definition/src/compiler/analysis/definitions.rs

@@ -24,7 +24,7 @@ fn collect_top_level_items(analysis: &mut Analysis) {
         }
 
         analysis.metadata.insert(
-            (**name).to_owned(),
+            (**name).clone(),
             ItemMetadata {
                 name: name.clone(),
                 item: item.clone(),

crates/codegen/language/definition/src/compiler/analysis/references.rs

@@ -389,7 +389,7 @@ fn check_reference(
     if let Some(source) = source {
         analysis.metadata[source]
             .referenced_items
-            .push((**reference).to_owned());
+            .push((**reference).clone());
     }
 }
 

crates/codegen/language/definition/src/compiler/version_set.rs

@@ -45,10 +45,10 @@ impl VersionSet {
             // there is some overlap:
             //  make sure 'range' is included in 'from..till', then remove it:
             if range.start < from {
-                from = range.start.to_owned();
+                from = range.start.clone();
             }
             if till < range.end {
-                till = range.end.to_owned();
+                till = range.end.clone();
             }
             false
         });
@@ -89,7 +89,7 @@ impl VersionSet {
 
             if first.start < second.start {
                 // take part of first that exists before second:
-                ranges.push(first.start.to_owned()..second.start.to_owned());
+                ranges.push(first.start.clone()..second.start.clone());
             }
 
             if first.end <= second.end {
@@ -99,7 +99,7 @@ impl VersionSet {
             }
 
             // keep part of first that exists after second:
-            first.start = second.end.to_owned();
+            first.start = second.end.clone();
 
             // advance second, as it's been fully processed:
             second_iter.next();

crates/codegen/language/internal_macros/src/lib.rs

@@ -10,7 +10,7 @@ use crate::input_model::InputItem;
 pub fn derive_spanned_type(args: TokenStream, mut input: TokenStream) -> TokenStream {
     let spanned_type = {
         let spanned_derive_args = args.into();
-        let input = input.to_owned();
+        let input = input.clone();
 
         let item = syn::parse_macro_input!(input as InputItem);
         derive::spanned(item, spanned_derive_args)

crates/infra/utils/src/cargo/workspace.rs

@@ -22,7 +22,7 @@ impl CargoWorkspace {
             .get(crate_name)
             .with_context(|| format!("Cannot find dependency '{crate_name}' in workspace."))?
             .version
-            .to_owned()
+            .clone()
             .with_context(|| {
                 format!("Dependency '{crate_name}' did not specify a version in Cargo.toml.")
             })?
@@ -47,7 +47,7 @@ impl CargoWorkspace {
             .get(crate_name)
             .with_context(|| format!("Cannot find dependency '{crate_name}' in workspace."))?
             .path
-            .to_owned()
+            .clone()
             .with_context(|| {
                 format!("Dependency '{crate_name}' did not specify a path in Cargo.toml.")
             })?;

crates/infra/utils/src/commands/mod.rs

@@ -224,7 +224,7 @@ impl Display for Command {
             parts.push("&&".to_owned());
         }
 
-        parts.push(self.name.to_owned());
+        parts.push(self.name.clone());
 
         for arg in &self.args {
             let delimiter = if arg.contains(' ') {

crates/solidity/testing/solc/src/commands/keyword_versioning.rs

@@ -133,7 +133,7 @@ impl KeywordVersioningCommand {
 
                 for variation in variations {
                     assert!(
-                        already_seen.insert((&item.identifier, variation.to_owned())),
+                        already_seen.insert((&item.identifier, variation.clone())),
                         "Duplicate variation: {variation}"
                     );