Always exit when a lint command fails

Now that we have an opt-in list for the Clippy, it makes sense to
gradually decrease the accepted lint list so that we won't regress while
migrating.

crates/infra/cli/src/commands/lint/mod.rs

@@ -87,8 +87,7 @@ fn run_clippy() -> Result<()> {
     let mut clippy = Command::new("cargo")
         .flag("clippy")
         .flag("--")
-        .flag("--verbose")
-        .exit_on_failure(false);
+        .flag("--verbose");
 
     for lint in allowed_lints {
         clippy = clippy.property("-A", format!("clippy::{}", lint));

crates/infra/utils/src/commands/mod.rs

@@ -23,8 +23,6 @@ pub struct Command {
     args: Vec<String>,
     environment: HashMap<String, String>,
     current_dir: Option<PathBuf>,
-    /// Whether the command failure should cause the entire process to exit.
-    exit_on_failure: bool,
 }
 
 impl Command {
@@ -34,7 +32,6 @@ impl Command {
             args: vec![],
             environment: HashMap::new(),
             current_dir: None,
-            exit_on_failure: true,
         };
     }
 
@@ -80,15 +77,6 @@ impl Command {
         return self;
     }
 
-    /// Whether the command failure should cause the entire process to exit.
-    ///
-    /// Defaults to `true`.
-    pub fn exit_on_failure(mut self, exit_on_failure: bool) -> Self {
-        self.exit_on_failure = exit_on_failure;
-
-        self
-    }
-
     pub fn evaluate(&self) -> Result<String> {
         let output = spawn_with_defaults(self, Stdio::piped)?
             .wait_with_output()
@@ -146,11 +134,7 @@ fn run_with_defaults(command: &Command) -> Result<()> {
     check_status(command, status).map_err(|error| {
         // Print error and exit process, to skip printing irrelevant backtraces from the parent process:
         eprintln!("{error}");
-        if command.exit_on_failure {
-            std::process::exit(1);
-        } else {
-            error
-        }
+        std::process::exit(1);
     })
 }