Introduce ErrorParametersDeclaration in v0/v1

crates/solidity/inputs/language/definition/02-definitions/12-errors/productions.yml

@@ -9,17 +9,23 @@
           sequence:
             - reference: "ErrorKeyword"
             - reference: "Identifier"
-            - delimitedBy:
-                open:
-                  reference: "OpenParen"
-                parser:
-                  optional:
-                    reference: "ErrorParametersList"
-                close:
-                  reference: "CloseParen"
+            - reference: "ErrorParametersDeclaration"
         terminator:
           reference: "Semicolon"
 
+- name: "ErrorParametersDeclaration"
+  kind: "Parser"
+  versioned:
+    0.8.4:
+      delimitedBy:
+        open:
+          reference: "OpenParen"
+        parser:
+          optional:
+            reference: "ErrorParametersList"
+        close:
+          reference: "CloseParen"
+
 - name: "ErrorParametersList"
   kind: "Parser"
   versioned:

crates/solidity/inputs/language/src/dsl.rs

@@ -271,7 +271,9 @@ slang_grammar! {
 
         inline parser EqualityComparisonOperator = (EqualEqual | BangEqual) ;
 
-        parser ErrorDefinition = { introduced in "0.8.4" ((ErrorKeyword Identifier ((ErrorParametersList ?) delimited by OpenParen and CloseParen)) terminated by Semicolon) } ;
+        parser ErrorDefinition = { introduced in "0.8.4" ((ErrorKeyword Identifier ErrorParametersDeclaration) terminated by Semicolon) } ;
+
+        parser ErrorParametersDeclaration = { introduced in "0.8.4" ((ErrorParametersList ?) delimited by OpenParen and CloseParen) } ;
 
         parser ErrorParameter = { introduced in "0.8.4" (TypeName (Identifier ?)) } ;
 

crates/solidity/testing/snapshots/cst_output/ContractDefinition/member_error_definition/generated/0.8.4-success.yml

@@ -16,7 +16,8 @@ Tree:
           - ErrorDefinition (Rule): # 18..36 "  error Error1();\n"
               - ErrorKeyword (Token): "error" # 20..25
               - Identifier (Token): "Error1" # 26..32
-              - OpenParen (Token): "(" # 32..33
-              - CloseParen (Token): ")" # 33..34
+              - ErrorParametersDeclaration (Rule): # 32..34 "()"
+                  - OpenParen (Token): "(" # 32..33
+                  - CloseParen (Token): ")" # 33..34
               - Semicolon (Token): ";" # 34..35
       - CloseBrace (Token): "}" # 36..37

crates/solidity/testing/snapshots/cst_output/ErrorDefinition/top_level/generated/0.8.4-success.yml

@@ -9,6 +9,7 @@ Tree:
   - ErrorDefinition (Rule): # 0..16 "error MyError();"
       - ErrorKeyword (Token): "error" # 0..5
       - Identifier (Token): "MyError" # 6..13
-      - OpenParen (Token): "(" # 13..14
-      - CloseParen (Token): ")" # 14..15
+      - ErrorParametersDeclaration (Rule): # 13..15 "()"
+          - OpenParen (Token): "(" # 13..14
+          - CloseParen (Token): ")" # 14..15
       - Semicolon (Token): ";" # 15..16

crates/solidity/testing/snapshots/cst_output/SourceUnit/everything/generated/0.8.13-failure.yml

@@ -117,12 +117,13 @@ Tree:
           - ErrorDefinition (Rule): # 181..200 "\nerror E1(string);\n"
               - ErrorKeyword (Token): "error" # 182..187
               - Identifier (Token): "E1" # 188..190
-              - OpenParen (Token): "(" # 190..191
-              - ErrorParametersList (Rule): # 191..197 "string"
-                  - ErrorParameter (Rule): # 191..197 "string"
-                      - TypeName (Rule): # 191..197 "string"
-                          - StringKeyword (Token): "string" # 191..197
-              - CloseParen (Token): ")" # 197..198
+              - ErrorParametersDeclaration (Rule): # 190..198 "(string)"
+                  - OpenParen (Token): "(" # 190..191
+                  - ErrorParametersList (Rule): # 191..197 "string"
+                      - ErrorParameter (Rule): # 191..197 "string"
+                          - TypeName (Rule): # 191..197 "string"
+                              - StringKeyword (Token): "string" # 191..197
+                  - CloseParen (Token): ")" # 197..198
               - Semicolon (Token): ";" # 198..199
           - UserDefinedValueTypeDefinition (Rule): # 200..217 "\ntype T is bool;\n"
               - TypeKeyword (Token): "type" # 201..205