Simplify helper method signature

XYOracleNetwork · Dec 18, 2024 · b8f0c70 · b8f0c70
1 parent b0f596e
commit b8f0c70
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/packages/modules/packages/node/packages/memory/src/NodeHelper/attachToNewNode.ts b/packages/modules/packages/node/packages/memory/src/NodeHelper/attachToNewNode.ts
@@ -1,11 +1,17 @@
 import type { ModuleIdentifier } from '@xyo-network/module-model'
-import type { NodeInstance } from '@xyo-network/node-model'
+import { NodeConfigSchema, type NodeInstance } from '@xyo-network/node-model'
 
 import type { MemoryNodeParams } from '../MemoryNode.ts'
 import { MemoryNode } from '../MemoryNode.ts'
 import { attachToExistingNode } from './attachToExistingNode.ts'
 
-export const attachToNewNode = async (source: NodeInstance, id: ModuleIdentifier, destinationParams: MemoryNodeParams): Promise<NodeInstance> => {
+const DEFAULT_NODE_PARAMS = { config: { schema: NodeConfigSchema } }
+
+export const attachToNewNode = async (
+  source: NodeInstance,
+  id: ModuleIdentifier,
+  destinationParams: MemoryNodeParams = DEFAULT_NODE_PARAMS,
+): Promise<NodeInstance> => {
   const destination = await MemoryNode.create(destinationParams)
   return await attachToExistingNode(source, id, destination)
 }
diff --git a/packages/modules/packages/node/src/spec/MemoryNode/MemoryNode.spec.ts b/packages/modules/packages/node/src/spec/MemoryNode/MemoryNode.spec.ts
@@ -311,7 +311,7 @@ describe('MemoryNode', () => {
         expect(prettyPrintDescription(description)).toMatchSnapshot()
       })
       it('clone-all', async () => {
-        const newNode = await MemoryNodeHelper.attachToNewNode(node, '*', { config: { schema: NodeConfigSchema } })
+        const newNode = await MemoryNodeHelper.attachToNewNode(node, '*')
         const newNodeChildren = await newNode.publicChildren()
         const nodeChildren = await node.publicChildren()
         expect(newNodeChildren.length).toEqual(nodeChildren.length)
@@ -322,7 +322,7 @@ describe('MemoryNode', () => {
         await node.register(mod)
         await node.attach(mod.address, true)
 
-        const newNode = await MemoryNodeHelper.attachToNewNode(node, 'CloneModule', { config: { schema: NodeConfigSchema } })
+        const newNode = await MemoryNodeHelper.attachToNewNode(node, 'CloneModule')
         const newNodeChild = await newNode.resolve('CloneModule')
         const nodeChild = await node.resolve('CloneModule', { maxDepth: 1 })
         expect(newNodeChild?.id).toEqual(nodeChild?.id)
@@ -336,7 +336,7 @@ describe('MemoryNode', () => {
 
         try {
           // this should except
-          await MemoryNodeHelper.attachToNewNode(node, 'CloneModulePrivate', { config: { schema: NodeConfigSchema } })
+          await MemoryNodeHelper.attachToNewNode(node, 'CloneModulePrivate')
           expect(false).toBeTrue()
         } catch (e) {
           expect(e).toBeInstanceOf(Error)