Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add node v22 and npm v10 support #2695

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat: add node v22 and npm v10 support #2695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0974c3a
add node 22 support
mvadari May 15, 2024
ed5b400
add debug stuff
mvadari May 15, 2024
ad29606
try upgrading npm
mvadari May 15, 2024
cea1812
remove node 16
mvadari May 15, 2024
709f71f
debug
mvadari May 15, 2024
614485a
Merge branch 'main' into node-22
mvadari Jul 3, 2024
7e6df39
remove tmux
mvadari Jul 11, 2024
210fc84
Merge branch 'main' into node-22
mvadari Sep 17, 2024
76d3cdf
only allow 22.9 onwards
mvadari Oct 11, 2024
c8ecaf7
Merge branch 'main' into node-22
mvadari Oct 11, 2024
7cff723
try 22.8
mvadari Oct 11, 2024
942243d
try 22.7
mvadari Oct 11, 2024
20117c9
test more 22.x versions
mvadari Oct 11, 2024
26928c5
test more versions
mvadari Oct 11, 2024
5aafe0b
switch back to 22.x, clean up
mvadari Oct 11, 2024
6995f3e
update README
mvadari Oct 11, 2024
900590a
Merge branch 'main' into node-22
mvadari Oct 11, 2024
dc6010d
Merge branch 'main' into node-22
mvadari Oct 21, 2024
18c7ff9
Merge branch 'main' into node-22
mvadari Nov 4, 2024
2136820
Merge branch 'main' into node-22
mvadari Nov 7, 2024
bdb0ac8
Merge branch 'main' into node-22
mvadari Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Setup npm version 9
- name: Setup npm version 10
run: |
npm i -g npm@9 --registry=https://registry.npmjs.org
npm i -g npm@10 --registry=https://registry.npmjs.org

- name: Cache node modules
id: cache-nodemodules
Expand All @@ -45,7 +45,6 @@ jobs:
key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-deps-${{ matrix.node-version }}-
${{ runner.os }}-deps-

- name: Install Dependencies
if: steps.cache-nodemodules.outputs.cache-hit != 'true'
Expand All @@ -60,7 +59,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.x, 22.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -69,9 +68,9 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Setup npm version 9
- name: Setup npm version 10
run: |
npm i -g npm@9 --registry=https://registry.npmjs.org
npm i -g npm@10 --registry=https://registry.npmjs.org

- name: Cache node modules
id: cache-nodemodules
Expand All @@ -86,7 +85,6 @@ jobs:
key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-deps-${{ matrix.node-version }}-
${{ runner.os }}-deps-

- name: Install Dependencies
if: steps.cache-nodemodules.outputs.cache-hit != 'true'
Expand All @@ -101,7 +99,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.x, 22.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -115,9 +113,9 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Setup npm version 9
- name: Setup npm version 10
run: |
npm i -g npm@9 --registry=https://registry.npmjs.org
npm i -g npm@10 --registry=https://registry.npmjs.org

- name: Cache node modules
id: cache-nodemodules
Expand All @@ -132,7 +130,6 @@ jobs:
key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-deps-${{ matrix.node-version }}-
${{ runner.os }}-deps-

- name: Install Dependencies
if: steps.cache-nodemodules.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -167,9 +164,9 @@ jobs:
run: |
docker run --detach --rm --name rippled-service -p 6006:6006 --volume "${{ github.workspace }}/.ci-config/":"/opt/ripple/etc/" --health-cmd="wget localhost:6006 || exit 1" --health-interval=5s --health-retries=10 --health-timeout=2s --env GITHUB_ACTIONS=true --env CI=true ${{ env.RIPPLED_DOCKER_IMAGE }} /opt/ripple/bin/rippled -a --conf /opt/ripple/etc/rippled.cfg

- name: Setup npm version 9
- name: Setup npm version 10
run: |
npm i -g npm@9 --registry=https://registry.npmjs.org
npm i -g npm@10 --registry=https://registry.npmjs.org

- name: Cache node modules
id: cache-nodemodules
Expand All @@ -184,7 +181,6 @@ jobs:
key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-deps-${{ matrix.node-version }}-
${{ runner.os }}-deps-

- name: Install Dependencies
if: steps.cache-nodemodules.outputs.cache-hit != 'true'
Expand All @@ -205,7 +201,7 @@ jobs:

strategy:
matrix:
node-version: [18.x, 20.x]
node-version: [18.x, 20.x, 22.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -214,9 +210,9 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Setup npm version 9
- name: Setup npm version 10
run: |
npm i -g npm@9 --registry=https://registry.npmjs.org
npm i -g npm@10 --registry=https://registry.npmjs.org

- name: Cache node modules
id: cache-nodemodules
Expand All @@ -231,7 +227,6 @@ jobs:
key: ${{ runner.os }}-deps-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-deps-${{ matrix.node-version }}-
${{ runner.os }}-deps-

- name: Install Dependencies
if: steps.cache-nodemodules.outputs.cache-hit != 'true'
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ All of which works in Node.js (tested for v18+) & web browsers (tested for Chrom

### Requirements

+ **[Node.js v18](https://nodejs.org/)** is recommended. We also support v20. Other versions may work but are not frequently tested.
+ **[Node.js v18](https://nodejs.org/)** is recommended. We also support v20 and v22. Other versions may work but are not frequently tested.

### Installing xrpl.js

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,6 @@
],
"engines": {
"node": ">=18.0.0",
"npm": ">=7.10.0 < 10.0.0"
"npm": ">=7.10.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the CI adhere to the minimum supported version of npm ? If users who use npm@v7 experience any problems with xrpl.js, we won't detect it since we are upgrading to npm@v10.

}
}
Loading