-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The tracks are now sorted and have the "#" attribute #3
base: master
Are you sure you want to change the base?
Conversation
File was downloaded from YouTube https://www.youtube.com/watch?v=P2JpGrvfGMs
File was downloaded from YouTube https://www.youtube.com/watch?v=UvpPwjkIjDE
Two songs: 1. Skippin' Service (downloaded from https://www.youtube.com/watch?v=0Devs3tcsls) 2. Lost at Sea (downloaded from https://www.youtube.com/watch?v=OPmeTb1r7K0)
File was downloaded from YouTube https://www.youtube.com/watch?v=Jnb61NQwWQs
File was downloaded from YouTube https://www.youtube.com/watch?v=tJqV3Z_WXas
Three songs: 1. The Hidden Horrors (downloaded from https://www.youtube.com/watch?v=AvpAN0U4FdA) 2. A Twisted Fate (downloaded from https://www.youtube.com/watch?v=8hkk3pVclTQ) 3. A Spineless Screech (downloaded from https://www.youtube.com/watch?v=itOmJ4tjjgk)
Track downloaded from YouTube: https://www.youtube.com/watch?v=gvGWZw-RcxY
These tracks are represented by empty (and identical) .mp3 files When these songs are released, they can easily replace the empty files The four songs are: 1. Funeral Service ar 10 o'clock (Death's Realm) 2. Prelude to Insanity (Corrupted Dungeons' Entrances) 3. Out Of Time (Corrupted Dungeons 2) 4. A Frightening Find (Silent Expanse Discovery)
Maybe it will make displaying the order of the songs easier in GitHub or something...
All the tracks have number from 1 to 164 in their "#" attribute. My reasoning for this order can be found in this shared TODO list (as notes) https://to-do.microsoft.com/sharing?InvitationToken=cI0_-u7TDBk2a3NRmRwX8Qw1BhzaSES9PyCVcRAPb-_wg4vfOtAZ6RPso-VQTQpQg All in all, the order is based on the likely order an average player hears the songs in the game.
Each track now has only one copy with its number in the "music" folder again.
Somebody might want to rewrite that one line. I just thought I will edit this in case others forget to update it.
Not sure why it reports a conflict, I renamed the file to have the same name and did no other changes apart from adding the "#" attribute. 😕 |
This track was missing before, the placeholder file was replaced The track was downloaded from https://youtu.be/WfXgPxEGMro
Since this still wasn't merged, I added the track for Death's Realm, which has been published recently here. Metadata are in the same format as in other files. |
Oh crap! Since you did not ask for a review I was not notified about this PR! |
Oh, sorry, my bad. I am still not very experienced with GitHub and didn't know that I need to ask for a review. I know that you'll want ti check everything yourself just to make sure, but here are the exact steps I took when adding songs or setting their # attribute.
And for the track for the Twain Mansion, I renamed it to have the same name as on your master branch. Hope this helps. |
Hi! I don't know how this is going, but if you are interested in the missing 4 pieces: Corkian Madness (Dwelling walls), Prelude to Insanity, Out of Time (Corrupted dungeons) and A Frightening Find (SE discovery), I exported them from ONBS to mp3, so they are as close as they can be. Also, as a bonus I included the modified version of Energetic encounter played at the Misadventures on the Sea giant rat boss fight. |
Thanks a lot, I'll definitelly add them. But it'll be very annoying to rearrange the songs order by shifting their numbers by one or two. I'll probably wait with that before the 1.20 music gets released, so I don't have to do it all over again. By the way, anyone, don't you know any software that would allow me to sort the tracks by dragging them and then export the whole playlist with the # attributes? |
This track was missing before, the placeholder file was replaced The track was provided by GitHub user 4321ba (https://github.com/4321ba)
This track was missing before, the placeholder file was replaced The track was provided by GitHub user 4321ba (https://github.com/4321ba)
This track was missing before, the placeholder file was replaced The track was provided by GitHub user 4321ba (https://github.com/4321ba)
Removed the "(missings)" marks from all tracks that were added recently
Yeah, that's right, shifting could be really annoying. I have never worked with these tags, I'm using Juk as music player https://apps.kde.org/en/juk and it can edit tags, but I don't think it can do what you need to do. |
There were some tracks that were already published but were missing in the repository (for example the Discovery Jingle or the series of the Journey Beyond songs); these were downloaded from YouTube (see commit messages for links) and sorted along with others.
Some songs are announced but weren't published yet. To make their future inclusion easier, they are now represented by empty
.mp3
files, their author is set toUnknown
and their album is set according to Wynncraft Wiki. When these are published, they can easily replace the empty files without the need to reindex all the tracks.About the mechanism of ordering, I've already explained this on Wynncraft forums, so here is a link with more information. (In case of forum wipe, you can use this archived copy of the thread).
None of the existing files was renamed, so if their names are used by Wynntils music player, it shouldn't cause any problems. The only thing I can think of is, that the empty files might override game music for those areas. So if it works like this, you might want to rename them to not override the online music. List of empty tracks is mentioned in the commit message of 512dfdc