Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to remove our custom search html block with the code search block #113

Closed
wants to merge 3 commits into from

Conversation

dd32
Copy link
Member

@dd32 dd32 commented Jan 24, 2022

This is an attempt at migrating from using a custom html block to using the core search block.

This renders correctly, but I've not tested with FSE.

The HTML block is still needed, as there's no other way to wrap it in a <li/>..

The global-header__search-form class was removed, as I couldn't see any way to define it / didn't seem required with the CSS selector change - There's only so many search fields in the header.

Using esc_attr_*() inside JSON doesn't feel right, which is the reason for cb113fd instead.

See #13

Draft as this is not intended on being used straight away, just looking at what is needed

@ryelle
Copy link
Contributor

ryelle commented Feb 14, 2022

Closing since I've merged most of this code in with #155 (thanks for laying the groundwork 💯 )

@ryelle ryelle closed this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants