Attempt to remove our custom search html block with the code search block #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at migrating from using a custom html block to using the core search block.
This renders correctly, but I've not tested with FSE.
The HTML block is still needed, as there's no other way to wrap it in a
<li/>
..The
global-header__search-form
class was removed, as I couldn't see any way to define it / didn't seem required with the CSS selector change - There's only so many search fields in the header.Using
esc_attr_*()
inside JSON doesn't feel right, which is the reason for cb113fd instead.See #13
Draft as this is not intended on being used straight away, just looking at what is needed