-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rosetta styles: Use Noto Serif JP for headings #455
Conversation
The code looks fine across all the Pull Requests. I haven't tested this on my sandbox due to the complexity of setting it up, but I'm comfortable with merging this. Thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice 👍 👍 I checked various pages (sandboxed), and they all applied the new font as shown in the screenshots. (However, I still need to add a backslash \
for it to work on my end.)
Except for the text "始めましょう" doesn't seem to have the new font applied (I saw in the screenshots that its font was also changed). Will there be a commit later to update this font?
--
ps. I couldn't test it locally as it kept showing this error on the homepage to me
Fatal error: Uncaught Error: Call to undefined method WP_HTML_Tag_Processor::next_token() in /var/www/html/wp-content/plugins/gutenberg/build/block-library/blocks/button.php:44 Stack trace: #0 /var/www/html/wp-includes/class-wp-block.php(258): gutenberg_render_block_core_button(Array, '\n
I'm pretty sure I've updated either node or composer packages to the latest version, have you also run into this, got stuck for a while 🫠
Only places that currently use the "heading font" (EB Garamond) will be updated, if we need to change "始めましょう" it will need different CSS. I don't see that specifically requested in #432, though.
I don't think I've seen that specifically, but maybe the WP version in the env is outdated? That doesn't update with node or composer packages, you can run |
Ah, what I meant was that in the screenshots you provided, the font (or maybe just the size?) of "始めましょう" looks different. That's why I was wondering if there might be some changes that weren't applied in the code.
It doesn't seem to be a WordPress version issue. After deleting gutenberg and reinstalling, it worked. The previous I also tried cloning a new repo and building from scratch, and the error didn't show up, but t here's another error:
This caused the content to not be imported, resulting in a 404 error on the initial visit to the homepage (this can be resolved by adjusting the Reading Settings, though). Have you run into this, possibly a proxy issue I presume? |
Oh, I think my before screenshot was not quite up to date, it was missing this change to shrink the CTA font size.
Sounds like a proxy issue to me, but I don't think I've run into that exactly. |
Noto Serif JP is being added to the available fonts with WordPress/wporg-mu-plugins#630 & WordPress/wporg-parent-2021#144. This PR updates the main site to use Noto Serif JP for headings.
The font preloading is also updated here, so that ja.w.org only preloads Noto Serif, not EB Garamond.
Screenshots
How to test the changes in this Pull Request:
cjk
subset wporg-mu-plugins#630 (I know 😩)head
tagsNote that EB Garamond does still load, it's hardcoded in the the global header site title. It might also appear if the font is set at the block level. We could override
--wp--preset--font-family--eb-garamond
with Noto Serif JP if it should be eradicated totally.