Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Double hashed value for background-color #8083

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fix: Double hashed value for background-color #8083

wants to merge 1 commit into from
+2 −2

Conversation

carolinan
Copy link
Contributor

If a theme developer sets a background color value that uses a hash (#) , WordPress should not add an additional hash when outputting the relevant CSS. Duplicate hash symbols (##) breaks the CSS for the background color.

By replacing the hardcoded hash symbol with maybe_hash_hex_color, the hash is only added if it is needed.

Trac ticket: https://core.trac.wordpress.org/ticket/40057

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@carolinan
Fix double hashed value for background-color
82adc42 
If a theme developer sets a background color that uses a hash, WordPress should not add an additional hash when assigning the color value.
Duplicate hash symbols breaks the CSS for the background color.

By replacing the hardcoded hash symbol with maybe_hash_hex_color, the hash is only added if it is needed.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props poena.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carolinan