-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance tests: Fix date time log for commit #8072
Performance tests: Fix date time log for commit #8072
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
- name: Check date time | ||
run: echo "COMMITTED_AT_TEST=$(git show -s $GITHUB_SHA --format='%cI')" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After 2b7099c we get the Date time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the testing steps
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Great catch, this looks like a solid fix to me.
Committed in https://core.trac.wordpress.org/changeset/59570 |
Reopening because the commit was reverted, see https://core.trac.wordpress.org/ticket/62766#comment:5 I believe we need to reinstate the extra workflow step and run the |
@felixarntz I have set the ENV variable in the previous step ( tested in 07ec67d ). Hopefully, this fixes the issue. I'm not entirely sure how to test this locally. |
Co-authored-by: Pascal Birchler <[email protected]>
Co-authored-by: Pascal Birchler <[email protected]>
Co-authored-by: Pascal Birchler <[email protected]>
…hal27/wordpress-develop into fix/performance-log-data-time
Committed in https://core.trac.wordpress.org/changeset/59582, and working as expected now, see https://core.trac.wordpress.org/ticket/62766#comment:10 |
Trac ticket: https://core.trac.wordpress.org/ticket/62766
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.