Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Add Learn WordPress links to admin Help panel and default comment #7866

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

Infinite-Null
Copy link

@Infinite-Null Infinite-Null commented Nov 22, 2024

Trac ticket: #62510

Description

This PR adds Learn WordPress links to improve resource discoverability in two locations:

  1. The wp-admin Help panel
  2. The default comment text

Why

  • Helps users discover official WordPress learning resources more easily
  • Provides direct access to learning materials from within wp-admin

Screenshot:

After Patch

Copy link

github-actions bot commented Nov 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ankitkumarshah, kaitohm.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

To get started with moderating, editing, and deleting comments, please visit the Comments screen in the dashboard.
Commenter avatars come from <a href="%s">Gravatar</a>.'
To get started with moderating, editing, and deleting comments, please visit the Comments screen in the dashboard.
Commenter avatars come from <a href="%1$s">Gravatar</a>. Click here to <a href="%2$s">Learn WordPress</a>.'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should split this out onto a new line and add a little more context to the link.

Suggested change
Commenter avatars come from <a href="%1$s">Gravatar</a>. Click here to <a href="%2$s">Learn WordPress</a>.'
Commenter avatars come from <a href="%1$s">Gravatar</a>.
If you're new to WordPress, check at these free <a href="%2$s">online courses at Learn WordPress</a>.'

esc_url( __( 'https://gravatar.com/' ) )
esc_url( __( 'https://gravatar.com/' ) ),
/* translators: The localized Learn WordPress URL. */
esc_url( __( 'https://learn.wordpress.org/' ) )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will direct users to specific courses relevant to them.

Suggested change
esc_url( __( 'https://learn.wordpress.org/' ) )
esc_url( __( 'https://learn.wordpress.org/learning-pathway/user/' ) )

Copy link

@kaitohm kaitohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the link and wording in the default comment to direct users specifically to online courses on Learn.

@Infinite-Null Infinite-Null requested a review from kaitohm January 1, 2025 06:45
@Infinite-Null
Copy link
Author

Hi @kaitohm,
I have made the changes requested please have a look at it at your convenience.
Thank you!

Copy link

@kaitohm kaitohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The front end changes look great and are what the Training Team were looking for. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants