-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General: Add Learn WordPress links to admin Help panel and default comment #7866
base: trunk
Are you sure you want to change the base?
General: Add Learn WordPress links to admin Help panel and default comment #7866
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
src/wp-admin/includes/upgrade.php
Outdated
To get started with moderating, editing, and deleting comments, please visit the Comments screen in the dashboard. | ||
Commenter avatars come from <a href="%s">Gravatar</a>.' | ||
To get started with moderating, editing, and deleting comments, please visit the Comments screen in the dashboard. | ||
Commenter avatars come from <a href="%1$s">Gravatar</a>. Click here to <a href="%2$s">Learn WordPress</a>.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should split this out onto a new line and add a little more context to the link.
Commenter avatars come from <a href="%1$s">Gravatar</a>. Click here to <a href="%2$s">Learn WordPress</a>.' | |
Commenter avatars come from <a href="%1$s">Gravatar</a>. | |
If you're new to WordPress, check at these free <a href="%2$s">online courses at Learn WordPress</a>.' |
src/wp-admin/includes/upgrade.php
Outdated
esc_url( __( 'https://gravatar.com/' ) ) | ||
esc_url( __( 'https://gravatar.com/' ) ), | ||
/* translators: The localized Learn WordPress URL. */ | ||
esc_url( __( 'https://learn.wordpress.org/' ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will direct users to specific courses relevant to them.
esc_url( __( 'https://learn.wordpress.org/' ) ) | |
esc_url( __( 'https://learn.wordpress.org/learning-pathway/user/' ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the link and wording in the default comment to direct users specifically to online courses on Learn.
Hi @kaitohm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The front end changes look great and are what the Training Team were looking for. Thanks!
Trac ticket: #62510
Description
This PR adds Learn WordPress links to improve resource discoverability in two locations:
Why
Screenshot: