Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/trunk' into add/mariadb-11-4
Browse files Browse the repository at this point in the history
  • Loading branch information
desrosj committed Jan 7, 2025
2 parents 2038092 + 4a9a928 commit da2d16d
Show file tree
Hide file tree
Showing 60 changed files with 517 additions and 182 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ permissions: {}
jobs:
# Runs the performance test suite.
performance:
name: Performance tests ${{ matrix.memcached && '(with memcached)' || '' }}
name: ${{ matrix.multisite && 'Multisite' || 'Single site' }}
uses: WordPress/wordpress-develop/.github/workflows/reusable-performance.yml@trunk
permissions:
contents: read
Expand All @@ -41,8 +41,10 @@ jobs:
fail-fast: false
matrix:
memcached: [ true, false ]
multisite: [ true, false ]
with:
memcached: ${{ matrix.memcached }}
multisite: ${{ matrix.multisite }}
secrets:
CODEVITALS_PROJECT_TOKEN: ${{ secrets.CODEVITALS_PROJECT_TOKEN }}

Expand Down
38 changes: 24 additions & 14 deletions .github/workflows/reusable-performance.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
##
# A reusable workflow that runs the performance test suite.
##
name: Performance Tests
name: Run performance Tests

on:
workflow_call:
Expand All @@ -26,6 +26,11 @@ on:
required: false
type: 'boolean'
default: false
multisite:
description: 'Whether to use Multisite.'
required: false
type: 'boolean'
default: false
secrets:
CODEVITALS_PROJECT_TOKEN:
description: 'The authorization token for https://www.codevitals.run/project/wordpress.'
Expand Down Expand Up @@ -53,6 +58,7 @@ env:

LOCAL_PHP_MEMCACHED: ${{ inputs.memcached }}
LOCAL_PHP: ${{ inputs.php-version }}${{ 'latest' != inputs.php-version && '-fpm' || '' }}
LOCAL_MULTISITE: ${{ inputs.multisite }}

jobs:
# Performs the following steps:
Expand All @@ -65,9 +71,11 @@ jobs:
# - Install Playwright browsers.
# - Build WordPress.
# - Start Docker environment.
# - Install object cache drop-in.
# - Log running Docker containers.
# - Docker debug information.
# - Install WordPress.
# - Enable themes on Multisite.
# - Install WordPress Importer plugin.
# - Import mock data.
# - Deactivate WordPress Importer plugin.
Expand Down Expand Up @@ -98,7 +106,7 @@ jobs:
# - Publish performance results.
# - Ensure version-controlled files are not modified or deleted.
performance:
name: Run tests
name: ${{ inputs.multisite && 'Multisite' || 'Single site' }} / ${{ inputs.memcached && 'Memcached' || 'Default' }}
runs-on: ubuntu-latest
permissions:
contents: read
Expand Down Expand Up @@ -166,6 +174,14 @@ jobs:
- name: Install WordPress
run: npm run env:install

- name: Enable themes on Multisite
if: ${{ inputs.multisite }}
run: |
npm run env:cli -- theme enable twentytwentyone --network --path=/var/www/${{ env.LOCAL_DIR }}
npm run env:cli -- theme enable twentytwentythree --network --path=/var/www/${{ env.LOCAL_DIR }}
npm run env:cli -- theme enable twentytwentyfour --network --path=/var/www/${{ env.LOCAL_DIR }}
npm run env:cli -- theme enable twentytwentyfive --network --path=/var/www/${{ env.LOCAL_DIR }}
- name: Install WordPress Importer plugin
run: npm run env:cli -- plugin install wordpress-importer --activate --path=/var/www/${{ env.LOCAL_DIR }}

Expand Down Expand Up @@ -290,7 +306,7 @@ jobs:
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
if: always()
with:
name: performance-artifacts${{ inputs.memcached && '-memcached' || '' }}-${{ github.run_id }}
name: performance-artifacts${{ inputs.multisite && '-multisite' || '' }}${{ inputs.memcached && '-memcached' || '' }}-${{ github.run_id }}
path: artifacts
if-no-files-found: ignore
include-hidden-files: true
Expand All @@ -303,7 +319,7 @@ jobs:

- name: Set the base sha
# Only needed when publishing results.
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/trunk' && ! inputs.memcached }}
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/trunk' && ! inputs.memcached && ! inputs.multisite }}
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
id: base-sha
with:
Expand All @@ -314,21 +330,15 @@ jobs:
- name: Set commit details
# Only needed when publishing results.
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/trunk' && ! inputs.memcached }}
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
id: commit-timestamp
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const commit_details = await github.rest.git.getCommit({ owner: context.repo.owner, repo: context.repo.repo, commit_sha: context.sha });
return parseInt((new Date( commit_details.data.author.date ).getTime() / 1000).toFixed(0))
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/trunk' && ! inputs.memcached && ! inputs.multisite }}
# Write to an environment variable to have the output available in later steps of the job.
run: echo "COMMITTED_AT=$(git show -s $GITHUB_SHA --format='%cI')" >> $GITHUB_ENV

- name: Publish performance results
# Only publish results on pushes to trunk.
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/trunk' && ! inputs.memcached }}
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/trunk' && ! inputs.memcached && ! inputs.multisite }}
env:
BASE_SHA: ${{ steps.base-sha.outputs.result }}
COMMITTED_AT: ${{ steps.commit-timestamp.outputs.result }}
CODEVITALS_PROJECT_TOKEN: ${{ secrets.CODEVITALS_PROJECT_TOKEN }}
HOST_NAME: "www.codevitals.run"
run: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/reusable-phpunit-tests-v1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ jobs:
node --version
curl --version
git --version
svn --version
- name: Log running Docker containers
run: docker ps -a
Expand Down
10 changes: 5 additions & 5 deletions src/js/_enqueues/wp/customize/controls.js
Original file line number Diff line number Diff line change
Expand Up @@ -1530,7 +1530,7 @@
}

// Expand/Collapse accordion sections on click.
section.container.find( '.accordion-section-title button, .customize-section-back' ).on( 'click keydown', function( event ) {
section.container.find( '.accordion-section-title button, .customize-section-back, .accordion-section-title[tabindex]' ).on( 'click keydown', function( event ) {
if ( api.utils.isKeydownButNotEnterEvent( event ) ) {
return;
}
Expand Down Expand Up @@ -1605,7 +1605,7 @@
content = section.contentContainer,
overlay = section.headContainer.closest( '.wp-full-overlay' ),
backBtn = content.find( '.customize-section-back' ),
sectionTitle = section.headContainer.find( '.accordion-section-title button' ).first(),
sectionTitle = section.headContainer.find( '.accordion-section-title button, .accordion-section-title[tabindex]' ).first(),
expand, panel;

if ( expanded && ! content.hasClass( 'open' ) ) {
Expand Down Expand Up @@ -2694,7 +2694,7 @@
container = section.headContainer.closest( '.wp-full-overlay-sidebar-content' ),
content = section.contentContainer,
backBtn = content.find( '.customize-section-back' ),
sectionTitle = section.headContainer.find( '.accordion-section-title button' ).first(),
sectionTitle = section.headContainer.find( '.accordion-section-title button, .accordion-section-title[tabindex]' ).first(),
body = $( document.body ),
expand, panel;

Expand Down Expand Up @@ -2833,7 +2833,7 @@
var meta, panel = this;

// Expand/Collapse accordion sections on click.
panel.headContainer.find( '.accordion-section-title button' ).on( 'click keydown', function( event ) {
panel.headContainer.find( '.accordion-section-title button, .accordion-section-title[tabindex]' ).on( 'click keydown', function( event ) {
if ( api.utils.isKeydownButNotEnterEvent( event ) ) {
return;
}
Expand Down Expand Up @@ -2937,7 +2937,7 @@
accordionSection = panel.contentContainer,
overlay = accordionSection.closest( '.wp-full-overlay' ),
container = accordionSection.closest( '.wp-full-overlay-sidebar-content' ),
topPanel = panel.headContainer.find( '.accordion-section-title button' ),
topPanel = panel.headContainer.find( '.accordion-section-title button, .accordion-section-title[tabindex]' ),
backBtn = accordionSection.find( '.customize-panel-back' ),
childSections = panel.sections(),
skipTransition;
Expand Down
2 changes: 1 addition & 1 deletion src/license.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
WordPress - Web publishing software

Copyright 2011-2024 by the contributors
Copyright 2011-2025 by the contributors

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
Expand Down
14 changes: 14 additions & 0 deletions src/wp-admin/credits.php
Original file line number Diff line number Diff line change
Expand Up @@ -133,5 +133,19 @@
__( 'Release Lead' );
__( 'Release Design Lead' );
__( 'Release Deputy' );
__( 'Release Coordination' );
__( 'Minor Release Lead' );
__( 'Core Developer' );
__( 'Core Tech Lead' );
__( 'Core Triage Lead' );
__( 'Editor Tech Lead' );
__( 'Editor Triage Lead' );
__( 'Documentation Lead' );
__( 'Test Lead' );
__( 'Design Lead' );
__( 'Performance Lead' );
__( 'Default Theme Design Lead' );
__( 'Default Theme Development Lead' );
__( 'Tech Lead' );
__( 'Triage Lead' );
__( 'External Libraries' );
5 changes: 5 additions & 0 deletions src/wp-admin/css/about.css
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,12 @@
}

.about__section a.button.button-hero {
padding-top: 1.1875rem;
padding-bottom: 1.1875rem;
font-size: 1.5rem;
line-height: 1.4;
white-space: normal;
text-wrap: pretty;
}

.about__container ul {
Expand Down
5 changes: 2 additions & 3 deletions src/wp-admin/css/login.css
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,7 @@ p {
}

.login form {
margin-top: 20px;
margin-left: 0;
margin: 24px 0;
padding: 26px 24px;
font-weight: 400;
overflow: hidden;
Expand Down Expand Up @@ -284,7 +283,7 @@ p {
font-size: 20px;
font-weight: 400;
line-height: 1.3;
margin: 0 auto 25px;
margin: 0 auto 24px;
padding: 0;
text-decoration: none;
width: 84px;
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/css/media.css
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@

.media-item .pinkynail {
float: left;
margin: 0 10px 0 0;
margin: 14px;
max-height: 70px;
max-width: 70px;
}
Expand Down
1 change: 1 addition & 0 deletions src/wp-admin/css/themes.css
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,7 @@ body.folded .theme-browser ~ .theme-overlay .theme-wrap {
.theme-overlay .theme-screenshots {
width: 100%;
float: none;
margin: 0;
}

.theme-overlay .theme-info {
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-custom-background.php
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ public function admin_page() {
<input type="file" id="upload" name="import" />
<input type="hidden" name="action" value="save" />
<?php wp_nonce_field( 'custom-background-upload', '_wpnonce-custom-background-upload' ); ?>
<?php submit_button( __( 'Upload' ), '', 'submit', false ); ?>
<?php submit_button( _x( 'Upload', 'verb' ), '', 'submit', false ); ?>
</p>
<p>
<label for="choose-from-library-link"><?php _e( 'Or choose an image from your media library:' ); ?></label><br />
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/class-custom-image-header.php
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ public function step_1() {
<input type="file" id="upload" name="import" />
<input type="hidden" name="action" value="save" />
<?php wp_nonce_field( 'custom-header-upload', '_wpnonce-custom-header-upload' ); ?>
<?php submit_button( __( 'Upload' ), '', 'submit', false ); ?>
<?php submit_button( _x( 'Upload', 'verb' ), '', 'submit', false ); ?>
</p>
<?php
$modal_update_href = add_query_arg(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function prepare_items() {
if ( 'search' === $tab ) {
$tabs['search'] = __( 'Search Results' );
}
$tabs['upload'] = __( 'Upload' );
$tabs['upload'] = _x( 'Upload', 'noun' );
$tabs['featured'] = _x( 'Featured', 'themes' );
//$tabs['popular'] = _x( 'Popular', 'themes' );
$tabs['new'] = _x( 'Latest', 'themes' );
Expand Down
4 changes: 2 additions & 2 deletions src/wp-admin/includes/credits.php
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,8 @@ function wp_credits_section_list( $credits = array(), $slug = '' ) {
echo '<li class="wp-person" id="wp-person-' . esc_attr( $person_data[2] ) . '">' . "\n\t";
echo '<a href="' . esc_url( sprintf( $credits_data['profiles'], $person_data[2] ) ) . '" class="web">';
$size = $compact ? 80 : 160;
$data = get_avatar_data( $person_data[1] . '@md5.gravatar.com', array( 'size' => $size ) );
$data2x = get_avatar_data( $person_data[1] . '@md5.gravatar.com', array( 'size' => $size * 2 ) );
$data = get_avatar_data( $person_data[1] . '@sha256.gravatar.com', array( 'size' => $size ) );
$data2x = get_avatar_data( $person_data[1] . '@sha256.gravatar.com', array( 'size' => $size * 2 ) );
echo '<span class="wp-person-avatar"><img src="' . esc_url( $data['url'] ) . '" srcset="' . esc_url( $data2x['url'] ) . ' 2x" class="gravatar" alt="" /></span>' . "\n";
echo esc_html( $person_data[0] ) . "</a>\n\t";
if ( ! $compact && ! empty( $person_data[3] ) ) {
Expand Down
4 changes: 2 additions & 2 deletions src/wp-admin/includes/media.php
Original file line number Diff line number Diff line change
Expand Up @@ -2277,11 +2277,11 @@ function media_upload_form( $errors = null ) {
<label class="screen-reader-text" for="async-upload">
<?php
/* translators: Hidden accessibility text. */
_e( 'Upload' );
_ex( 'Upload', 'verb' );
?>
</label>
<input type="file" name="async-upload" id="async-upload" />
<?php submit_button( __( 'Upload' ), 'primary', 'html-upload', false ); ?>
<?php submit_button( _x( 'Upload', 'verb' ), 'primary', 'html-upload', false ); ?>
<a href="#" onclick="try{top.tb_remove();}catch(e){}; return false;"><?php _e( 'Cancel' ); ?></a>
</p>
<div class="clear"></div>
Expand Down
9 changes: 4 additions & 5 deletions src/wp-admin/includes/template.php
Original file line number Diff line number Diff line change
Expand Up @@ -1784,12 +1784,11 @@ function do_settings_sections( $page ) {
call_user_func( $section['callback'], $section );
}

if ( ! isset( $wp_settings_fields ) || ! isset( $wp_settings_fields[ $page ] ) || ! isset( $wp_settings_fields[ $page ][ $section['id'] ] ) ) {
continue;
if ( isset( $wp_settings_fields[ $page ][ $section['id'] ] ) ) {
echo '<table class="form-table" role="presentation">';
do_settings_fields( $page, $section['id'] );
echo '</table>';
}
echo '<table class="form-table" role="presentation">';
do_settings_fields( $page, $section['id'] );
echo '</table>';

if ( '' !== $section['after_section'] ) {
echo wp_kses_post( $section['after_section'] );
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentyeleven/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ For more information about Twenty Eleven please go to https://codex.wordpress.or

== Copyright ==

Twenty Eleven WordPress Theme, Copyright 2011-2024 WordPress.org, Automattic Inc., and contributors.
Twenty Eleven WordPress Theme, Copyright 2011-2025 WordPress.org, Automattic Inc., and contributors.
Twenty Eleven is Distributed under the terms of the GNU GPL

This program is free software: you can redistribute it and/or modify
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentyfifteen/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ For more information about Twenty Fifteen please go to https://wordpress.org/doc

== Copyright ==

Twenty Fifteen WordPress Theme, Copyright 2014-2024 WordPress.org, Automattic Inc., and contributors.
Twenty Fifteen WordPress Theme, Copyright 2014-2025 WordPress.org, Automattic Inc., and contributors.
Twenty Fifteen is distributed under the terms of the GNU GPL

This program is free software: you can redistribute it and/or modify
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentyfourteen/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ For more information about Twenty Fourteen please go to https://codex.wordpress.

== Copyright ==

Twenty Fourteen WordPress Theme, Copyright 2013-2024 WordPress.org, Automattic Inc., and contributors.
Twenty Fourteen WordPress Theme, Copyright 2013-2025 WordPress.org, Automattic Inc., and contributors.
Twenty Fourteen is Distributed under the terms of the GNU GPL

This program is free software: you can redistribute it and/or modify
Expand Down
4 changes: 2 additions & 2 deletions src/wp-content/themes/twentynineteen/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ For more information about Twenty Nineteen please go to https://wordpress.org/do

== Copyright ==

Twenty Nineteen WordPress Theme, Copyright 2018-2024 WordPress.org, and contributors.
Twenty Nineteen WordPress Theme, Copyright 2018-2025 WordPress.org, and contributors.
Twenty Nineteen is distributed under the terms of the GNU GPL

This program is free software: you can redistribute it and/or modify
Expand Down Expand Up @@ -147,7 +147,7 @@ Initial release

== Resources ==
* normalize.css, © 2012-2018 Nicolas Gallagher and Jonathan Neal, MIT
* Underscores, © 2012-2024 Automattic, Inc., GNU GPL v2 or later
* Underscores, © 2012-2025 Automattic, Inc., GNU GPL v2 or later
* Bundled block pattern images:
* Abstract Background by HD Wallpapers, CC0. https://stocksnap.io/photo/abstract-background-0SRRVNMKBX
* Abstract Waves by HD Wallpapers, CC0. https://stocksnap.io/photo/abstract-waves-0KREGLTZQ3
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentyseventeen/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ For more information about Twenty Seventeen please go to https://wordpress.org/d

== Copyright ==

Twenty Seventeen WordPress Theme, Copyright 2016-2024 WordPress.org, and contributors.
Twenty Seventeen WordPress Theme, Copyright 2016-2025 WordPress.org, and contributors.
Twenty Seventeen is distributed under the terms of the GNU GPL

This program is free software: you can redistribute it and/or modify
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentysixteen/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ For more information about Twenty Sixteen please go to https://wordpress.org/doc

== Copyright ==

Twenty Sixteen WordPress Theme, Copyright 2014-2024 WordPress.org, and contributors.
Twenty Sixteen WordPress Theme, Copyright 2014-2025 WordPress.org, and contributors.
Twenty Sixteen is distributed under the terms of the GNU GPL

This program is free software: you can redistribute it and/or modify
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentyten/readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ For more information about Twenty Ten theme please go to https://codex.wordpress

== Copyright ==

Twenty Ten WordPress Theme, Copyright 2010-2024 WordPress.org, Automattic Inc., and contributors.
Twenty Ten WordPress Theme, Copyright 2010-2025 WordPress.org, Automattic Inc., and contributors.
Twenty Ten is Distributed under the terms of the GNU GPL

This program is free software: you can redistribute it and/or modify
Expand Down
Loading

0 comments on commit da2d16d

Please sign in to comment.