Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

fix: layout breaks when there are many categories in default single p… #648

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: layout breaks when there are many categories in default single p… #648

merged 1 commit into from
Oct 28, 2024

Conversation

alaminfirdows
Copy link
Contributor

@alaminfirdows alaminfirdows commented Oct 28, 2024 •
edited
Loading

Description
Closes #644

This PR fixes the issue where the layout breaks when there are many categories in the default single post template. Changing the flexWrap property of the parent group from nowrap to wrap resolves this.

Screenshots
image

Testing Instructions

Install https://github.com/WordPress/theme-test-data
view the "Edge Case: Many Categories" post.

Alternatively, create a post with more categories (about 10+) and view the post.

@github-actions GitHub Actions
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: alaminfirdows <[email protected]>
Co-authored-by: beafialho <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@alaminfirdows alaminfirdows mentioned this pull request Oct 28, 2024
Closed
juanfra
juanfra approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me.

Screen.Recording.2024-10-28.at.19.48.16.mov

@juanfra juanfra merged commit d6abbce into WordPress:trunk Oct 28, 2024
5 checks passed
@alaminfirdows alaminfirdows deleted the fix-644 branch October 28, 2024 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanfra juanfra juanfra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default single post template: "Post meta" Layout breaks when there are many categories
2 participants
@alaminfirdows @juanfra