Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurate sizes: Get accurate sizes base on ancestor block context #1818

Draft
wants to merge 1 commit into
base: add/ancestor-block-context
Choose a base branch
from

Conversation

mukeshpanchal27
Copy link
Member

Summary

See #1511

@mukeshpanchal27 mukeshpanchal27 added [Type] Feature A new feature within an existing module no milestone PRs that do not have a defined milestone for release [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) labels Jan 22, 2025
@mukeshpanchal27 mukeshpanchal27 self-assigned this Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.77%. Comparing base (2c31b95) to head (ff1a7f2).

Files with missing lines Patch % Lines
...ns/auto-sizes/includes/improve-calculate-sizes.php 96.42% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           add/ancestor-block-context    #1818      +/-   ##
==============================================================
+ Coverage                       57.53%   57.77%   +0.24%     
==============================================================
  Files                              84       84              
  Lines                            6544     6567      +23     
==============================================================
+ Hits                             3765     3794      +29     
+ Misses                           2779     2773       -6     
Flag Coverage Δ
multisite 57.77% <96.42%> (+0.24%) ⬆️
single 34.97% <96.42%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mukeshpanchal27
Copy link
Member Author

@joemcgill This one ready for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Feature A new feature within an existing module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant