Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accurate Sizes: Incorporate layout constraints in image sizes calculations #1738

Merged
merged 59 commits into from
Dec 13, 2024
Merged

Accurate Sizes: Incorporate layout constraints in image sizes calculations #1738

merged 59 commits into from
Dec 13, 2024

Conversation

joemcgill
Copy link
Member

Summary

This PR is merges the initial support for incorporating layout constraints in the calculation of img sizes attributes into the Enhanced Responsive Images plugin.

See #1511

Relevant technical choices

PRs included:

mukeshpanchal27 and others added 30 commits October 22, 2024 20:29
@mukeshpanchal27
Update existing code with new approach
3d61681
@mukeshpanchal27
Merge pull request #1623 from WordPress/trunk
614b1a5 
Merge latest changes to feature branch
@mukeshpanchal27
Fix spell
4396c78
@mukeshpanchal27
Merge branch 'feature/1511-incorporate-layout-constraints-from-ancest…
8edeb67 
…ors' into update/use-filter-approach
@mukeshpanchal27
Disable lazy loading attribute for unit tests
af890e2
@mukeshpanchal27
Fix comment indention
d9af569
@mukeshpanchal27
Use HTML API for attachment cache
b87adcf
@mukeshpanchal27
Address review feedback
bfdab10
@mukeshpanchal27 @westonruter
Apply suggestions from code review
97dcb8f 
Co-authored-by: Weston Ruter <[email protected]>
@mukeshpanchal27 @westonruter
Add types for function variables
2cbf39d 
Co-authored-by: Weston Ruter <[email protected]>
@mukeshpanchal27
Fix lint PHP
4c7faa0
@mukeshpanchal27 @westonruter
Apply suggestions from code review
dd0e12b 
Co-authored-by: Weston Ruter <[email protected]>
@mukeshpanchal27
Remove unused parameter from auto_sizes_prime_attachment_caches()
fad4e87
@mukeshpanchal27
Fix PHPStan error
198f2cd
@mukeshpanchal27
Added inline comment for filter priority
de20e12
@felixarntz
Merge pull request #1663 from WordPress/trunk
9e276f1 
Merge latest changes to feature branch
@mukeshpanchal27
Merge branch 'feature/1511-incorporate-layout-constraints-from-ancest…
69ac2e1 
…ors' into update/use-filter-approach
@mukeshpanchal27
Update priority for prime attachement cache
ad51973
@mukeshpanchal27
Remove message
6b8747c
@mukeshpanchal27
Update function doc
c06b4e7
@joemcgill
Merge pull request #1625 from WordPress/update/use-filter-approach
6e9f892 
Accurate sizes: Calculate image sizes during block rendering
@joemcgill
Merge branch 'trunk' into feature/1511-incorporate-layout-constraints…
7f3e44d 
…-from-ancestors
@joemcgill
Separate file structure by feature
63b2544
@joemcgill
Rename /inc to /includes
7cd300a
@joemcgill
Rename test class
11a63e2
@joemcgill
Add tests for passing parent alignment context to images
042232f
@mukeshpanchal27
Merge pull request #1699 from WordPress/update/separate-file-structure
9ffe60c 
Auto sizes: Reorganize file structure by feature
@mukeshpanchal27
POC - Pass group block alignment context to image block
47c6779
@mukeshpanchal27
Fix spell
894ed57
@mukeshpanchal27
Clean up
cf8691a
joemcgill and others added 16 commits December 5, 2024 10:48
@joemcgill
Simplify passing of context for sizes calculation
9677bca 
This removes the need to pass whether there is a parent block by comparing the constraints of the parent block prior to calling `auto_sizes_calculate_width()`.
@joemcgill
Simplify context logic further
5c6f7fd
@joemcgill
Remove unused auto_sizes_get_width function
df8741f
@mukeshpanchal27
Minor docbock update
0790b92
@joemcgill
WIP: fix center alignments and cover blocks
8ca8b27
@mukeshpanchal27
Return accurate sizes for center alignment
83be032
@joemcgill
Improve cover block left/right alignment
d3a60d0
@joemcgill @westonruter
Initial review feedback improvements
266e457 
Co-authored-by: Weston Ruter <[email protected]>
@joemcgill
Force resize width to be an int
aecb3de
@joemcgill @westonruter
Additional type casting fixes
7fb1962 
Co-authored-by: Weston Ruter <[email protected]>
@joemcgill @felixarntz @westonruter
Merge pull request #1701 from WordPress/update/pass-alignment-by-context
59e86f8 
Accurate sizes: Pass parent alignment context to images

Co-authored-by: joemcgill <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: westonruter <[email protected]>
@joemcgill
Initial concept for supporting relative alingment widths
501c65e
@mukeshpanchal27
Revert unwanted doc indention changes
e69b2af
@joemcgill @westonruter
Chance typing for sprintf() placeholder
7dd60d5 
Co-authored-by: Weston Ruter <[email protected]>
@joemcgill
Add tests for relative alignment
35988a4
@joemcgill
Merge pull request #1737 from WordPress/update/1511-support-relative-…
aa340dc 
…alignment-widths

Accurate sizes: Support relative alignment widths
@joemcgill joemcgill added [Type] Feature A new feature within an existing module [Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) labels Dec 13, 2024
@joemcgill joemcgill added this to the auto-sizes n.e.x.t milestone Dec 13, 2024
@joemcgill joemcgill linked an issue Dec 13, 2024 that may be closed by this pull request
Incorporate layout constraints from ancestor blocks into the sizes calculations #1511
Open
@joemcgill joemcgill changed the title Auto Sizes: Incorporate layout constraints in image sizes calculations Accurate Sizes: Incorporate layout constraints in image sizes calculations Dec 13, 2024
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: joemcgill <[email protected]>
Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@joemcgill joemcgill merged commit 9c3d9e8 into trunk Dec 13, 2024
22 checks passed
@joemcgill joemcgill mentioned this pull request Dec 13, 2024
Open
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27 mukeshpanchal27 is a code owner

Assignees
No one assigned
Labels
[Plugin] Enhanced Responsive Images Issues for the Enhanced Responsive Images plugin (formerly Auto Sizes) [Type] Feature A new feature within an existing module
Projects
WP Performance 2024
Status: Done 😃
Milestone
auto-sizes 1.4.0
Development

Successfully merging this pull request may close these issues.

Incorporate layout constraints from ancestor blocks into the sizes calculations
4 participants
@joemcgill @westonruter @mukeshpanchal27 @felixarntz