Account for plugin dependencies when storing relevant plugin info #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
requested review from
mukeshpanchal27 and
felixarntz
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
westonruter
force-pushed
the
fix/storing-standalone-plugin-info
branch
from
bd14a92
to
f385a43
Compare
westonruter
commented
Oct 21, 2024
| @@ -19,7 +19,7 @@ | |||
| * @return array{name: string, slug: string, short_description: string, requires: string|false, requires_php: string|false, requires_plugins: string[], download_link: string, version: string}|WP_Error Array of plugin data or WP_Error if failed. | |||
| */ | |||
| function perflab_query_plugin_info( string $plugin_slug ) { | |||
| $transient_key = 'perflab_plugins_info'; | |||
| $transient_key = 'perflab_plugins_info-v2'; | |||
There was a problem hiding this comment.
The transient key needs to be bumped since sites may already have downloaded bad plugin data with the old key.
There was a problem hiding this comment.
Seems like we should include a hash of the plugin version or something so that this type of bump would be unnecessary
There was a problem hiding this comment.
Oh, additionally, we should probably update the logic below so that if a slug is not found in the cache, it tries to request it from the API instead of returning a WP_Error right away.
There was a problem hiding this comment.
We could, but this is analogous to the $wp_db_version in core which doesn't necessarily need to change with each plugin release.
There was a problem hiding this comment.
Oh, additionally, we should probably update the logic below so that if a slug is not found in the cache, it tries to request it from the API instead of returning a
WP_Errorright away.
Yeah, that's a good idea too.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: swissspidy <[email protected]>
swissspidy
approved these changes
Oct 21, 2024
|
Updated build for testing: performance-lab.zip |
Post 3.5.0 release merge
… fix/storing-standalone-plugin-info
adamsilverstein
approved these changes
Oct 21, 2024
|
Pending release diffs from 3.5.0:
|
felixarntz
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Thanks @westonruter and everyone involved in fixing this so promptly in a hotfix!
While I understand how this resolves the problem, I wonder why optimization-detective is not part of the perflab_get_standalone_plugin_data() list in the first place. Did we not want to include it only because it's an infrastructure plugin?
| $standalone_plugins = array_flip( perflab_get_standalone_plugins() ); | ||
| $standalone_plugins = array_merge( | ||
| array_flip( perflab_get_standalone_plugins() ), | ||
| array( 'optimization-detective' => array() ) // TODO: Programmatically discover the plugin dependencies and add them here. |
There was a problem hiding this comment.
Is there an issue already for this?
@felixarntz I recall it was to avoid having Optimization Detective as a separate feature listed on the Performance screen since it doesn't provide features on its own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up hotfix to #1573 which broke the ability to install the Image Prioritizer plugin from the Performance features screen since the fetched plugin info did not include plugin dependencies, specifically Optimization Detective.
This also bumps the plugin version to 3.5.1.