Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update content switcher tabs fonts and icons to match the mockups #2140

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Update content switcher tabs fonts and icons to match the mockups #2140

merged 3 commits into from
Feb 8, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Feb 3, 2023 •
edited
Loading

Fixes

Related to WordPress/openverse#482 by @panchovm

Description

This PR updates the content switcher tabs to match the mockups, and updates the visual regression tests for filters (adds the mobile tests and re-uses a single snapshot for all desktop filters)

This is the current state in staging:
Screenshot 2023-02-03 at 8 04 32 PM

This PR contains the updated tabs snapshots in the files.

Link to Figma: https://www.figma.com/file/KxkZmBNk218V2Fke1GeYCu/New-header-component?node-id=552%3A80105&t=W5pSIaV6s36yC3j1-4

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner February 3, 2023 17:08
@obulat obulat requested review from zackkrida and dhruvkb February 3, 2023 17:08
@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited
Loading

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/2140
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/2140/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 3, 2023
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited
Loading

Size Change: -12.5 kB (-1%)

Total Size: 886 kB

Filename Size Change
./.nuxt/dist/client/203.js 0 B -272 B (removed) 🏆
./.nuxt/dist/client/203.modern.js 0 B -276 B (removed) 🏆
./.nuxt/dist/client/204.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/app.js 142 kB -5.82 kB (-4%)
./.nuxt/dist/client/app.modern.js 114 kB -6.2 kB (-5%) ✅
./.nuxt/dist/client/commons/app.js 87.7 kB +10 B (0%)
./.nuxt/dist/client/commons/app.modern.js 78.2 kB -15 B (0%)
./.nuxt/dist/client/runtime.js 2.34 kB -240 B (-9%) ✅
./.nuxt/dist/client/runtime.modern.js 2.34 kB -244 B (-9%) ✅
./.nuxt/dist/client/155.js 273 B +273 B (new file) 🆕
./.nuxt/dist/client/155.modern.js 277 B +277 B (new file) 🆕
./.nuxt/dist/client/156.js 1.85 kB +1.85 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./.nuxt/dist/client/components/loading-icon.js 748 B 0 B
./.nuxt/dist/client/components/loading-icon.modern.js 749 B 0 B
./.nuxt/dist/client/components/table-sort-icon.js 508 B 0 B
./.nuxt/dist/client/components/table-sort-icon.modern.js 513 B 0 B
./.nuxt/dist/client/components/v-all-results-grid.js 7.5 kB 0 B
./.nuxt/dist/client/components/v-all-results-grid.modern.js 5.01 kB 0 B
./.nuxt/dist/client/components/v-audio-cell.js 355 B 0 B
./.nuxt/dist/client/components/v-audio-cell.modern.js 361 B 0 B
./.nuxt/dist/client/components/v-audio-details.js 2.54 kB 0 B
./.nuxt/dist/client/components/v-audio-details.modern.js 1.79 kB 0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB 0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB 0 B
./.nuxt/dist/client/components/v-audio-track.js 5.21 kB 0 B
./.nuxt/dist/client/components/v-audio-track.modern.js 5.16 kB +1 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.js 538 B 0 B
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 543 B 0 B
./.nuxt/dist/client/components/v-bone.js 685 B 0 B
./.nuxt/dist/client/components/v-bone.modern.js 689 B 0 B
./.nuxt/dist/client/components/v-box-layout.js 1.23 kB 0 B
./.nuxt/dist/client/components/v-box-layout.modern.js 1.23 kB 0 B
./.nuxt/dist/client/components/v-content-link.js 1.11 kB 0 B
./.nuxt/dist/client/components/v-content-link.modern.js 1.09 kB 0 B
./.nuxt/dist/client/components/v-content-page.js 466 B 0 B
./.nuxt/dist/client/components/v-content-page.modern.js 471 B 0 B
./.nuxt/dist/client/components/v-content-report-button.js 774 B 0 B
./.nuxt/dist/client/components/v-content-report-button.modern.js 781 B 0 B
./.nuxt/dist/client/components/v-content-report-form.js 6.1 kB 0 B
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.58 kB -1 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.js 1.23 kB 0 B
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.23 kB -1 B (0%)
./.nuxt/dist/client/components/v-copy-button.js 3.99 kB +1 B (0%)
./.nuxt/dist/client/components/v-copy-button.modern.js 3.99 kB 0 B
./.nuxt/dist/client/components/v-copy-license.js 1 kB 0 B
./.nuxt/dist/client/components/v-copy-license.modern.js 1 kB 0 B
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js 9.89 kB 0 B
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js 9.85 kB 0 B
./.nuxt/dist/client/components/v-dmca-notice.js 744 B 0 B
./.nuxt/dist/client/components/v-dmca-notice.modern.js 751 B 0 B
./.nuxt/dist/client/components/v-error-image.js 1.69 kB 0 B
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB 0 B
./.nuxt/dist/client/components/v-error-section.js 373 B 0 B
./.nuxt/dist/client/components/v-error-section.modern.js 376 B 0 B
./.nuxt/dist/client/components/v-external-search-form.js 2.07 kB 0 B
./.nuxt/dist/client/components/v-external-search-form.modern.js 2.05 kB 0 B
./.nuxt/dist/client/components/v-external-source-list.js 901 B 0 B
./.nuxt/dist/client/components/v-external-source-list.modern.js 900 B 0 B
./.nuxt/dist/client/components/v-full-layout.js 1.59 kB 0 B
./.nuxt/dist/client/components/v-full-layout.modern.js 1.59 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.js 1.62 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB 0 B
./.nuxt/dist/client/components/v-home-gallery.js 4.8 kB 0 B
./.nuxt/dist/client/components/v-home-gallery.modern.js 4.77 kB 0 B
./.nuxt/dist/client/components/v-homepage-content.js 1.72 kB 0 B
./.nuxt/dist/client/components/v-homepage-content.modern.js 1.69 kB 0 B
./.nuxt/dist/client/components/v-image-carousel.js 4.77 kB 0 B
./.nuxt/dist/client/components/v-image-carousel.modern.js 4.73 kB 0 B
./.nuxt/dist/client/components/v-image-cell-square.js 993 B 0 B
./.nuxt/dist/client/components/v-image-cell-square.modern.js 997 B 0 B
./.nuxt/dist/client/components/v-image-cell.js 1.43 kB 0 B
./.nuxt/dist/client/components/v-image-cell.modern.js 1.42 kB 0 B
./.nuxt/dist/client/components/v-image-details.js 2.15 kB 0 B
./.nuxt/dist/client/components/v-image-details.modern.js 1.42 kB 0 B
./.nuxt/dist/client/components/v-image-grid.js 4.88 kB 0 B
./.nuxt/dist/client/components/v-image-grid.modern.js 2.42 kB 0 B
./.nuxt/dist/client/components/v-license-tab-panel.js 521 B 0 B
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 525 B 0 B
./.nuxt/dist/client/components/v-load-more.js 3.16 kB 0 B
./.nuxt/dist/client/components/v-load-more.modern.js 683 B 0 B
./.nuxt/dist/client/components/v-media-license.js 819 B 0 B
./.nuxt/dist/client/components/v-media-license.modern.js 827 B 0 B
./.nuxt/dist/client/components/v-media-reuse.js 1.62 kB 0 B
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.61 kB 0 B
./.nuxt/dist/client/components/v-media-tag.js 428 B 0 B
./.nuxt/dist/client/components/v-media-tag.modern.js 434 B 0 B
./.nuxt/dist/client/components/v-no-results.js 752 B 0 B
./.nuxt/dist/client/components/v-no-results.modern.js 751 B 0 B
./.nuxt/dist/client/components/v-old-homepage-content.js 1.88 kB 0 B
./.nuxt/dist/client/components/v-old-homepage-content.modern.js 1.85 kB 0 B
./.nuxt/dist/client/components/v-radio.js 1.51 kB 0 B
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB -2 B (0%)
./.nuxt/dist/client/components/v-related-audio.js 1.25 kB 0 B
./.nuxt/dist/client/components/v-related-audio.modern.js 1.25 kB 0 B
./.nuxt/dist/client/components/v-related-images.js 1.05 kB 0 B
./.nuxt/dist/client/components/v-related-images.modern.js 2.98 kB 0 B
./.nuxt/dist/client/components/v-report-desc-form.js 965 B 0 B
./.nuxt/dist/client/components/v-report-desc-form.modern.js 968 B 0 B
./.nuxt/dist/client/components/v-row-layout.js 1.7 kB 0 B
./.nuxt/dist/client/components/v-row-layout.modern.js 1.71 kB 0 B
./.nuxt/dist/client/components/v-scroll-button.js 813 B 0 B
./.nuxt/dist/client/components/v-scroll-button.modern.js 819 B 0 B
./.nuxt/dist/client/components/v-search-grid.js 5.87 kB 0 B
./.nuxt/dist/client/components/v-search-grid.modern.js 5.8 kB 0 B
./.nuxt/dist/client/components/v-search-results-title.js 596 B 0 B
./.nuxt/dist/client/components/v-search-results-title.modern.js 599 B 0 B
./.nuxt/dist/client/components/v-search-type-radio.js 791 B 0 B
./.nuxt/dist/client/components/v-search-type-radio.modern.js 767 B 0 B
./.nuxt/dist/client/components/v-server-timeout.js 299 B 0 B
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 3.37 kB 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 894 B 0 B
./.nuxt/dist/client/components/v-skip-to-content-container.js 887 B 0 B
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 896 B 0 B
./.nuxt/dist/client/components/v-snackbar.js 1.18 kB 0 B
./.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB 0 B
./.nuxt/dist/client/components/v-sources-table.js 16.6 kB +1 B (0%)
./.nuxt/dist/client/components/v-sources-table.modern.js 16.6 kB -1 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.js 298 B 0 B
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 303 B 0 B
./.nuxt/dist/client/pages/about.js 1.52 kB -2 B (0%)
./.nuxt/dist/client/pages/about.modern.js 1.53 kB 0 B
./.nuxt/dist/client/pages/audio/_id/index.js 7.97 kB 0 B
./.nuxt/dist/client/pages/audio/_id/index.modern.js 4.8 kB 0 B
./.nuxt/dist/client/pages/external-sources.js 1.54 kB 0 B
./.nuxt/dist/client/pages/external-sources.modern.js 1.54 kB 0 B
./.nuxt/dist/client/pages/feedback.js 1.32 kB 0 B
./.nuxt/dist/client/pages/feedback.modern.js 1.32 kB 0 B
./.nuxt/dist/client/pages/image/_id/index.js 9.28 kB -1 B (0%)
./.nuxt/dist/client/pages/image/_id/index.modern.js 7.34 kB -2 B (0%)
./.nuxt/dist/client/pages/image/_id/report.js 3.59 kB 0 B
./.nuxt/dist/client/pages/image/_id/report.modern.js 4.2 kB +1 B (0%)
./.nuxt/dist/client/pages/index.js 8.64 kB -1 B (0%)
./.nuxt/dist/client/pages/index.modern.js 8.52 kB +3 B (0%)
./.nuxt/dist/client/pages/preferences.js 1.23 kB 0 B
./.nuxt/dist/client/pages/preferences.modern.js 1.22 kB 0 B
./.nuxt/dist/client/pages/privacy.js 994 B -1 B (0%)
./.nuxt/dist/client/pages/privacy.modern.js 993 B -2 B (0%)
./.nuxt/dist/client/pages/search-help.js 1.62 kB 0 B
./.nuxt/dist/client/pages/search-help.modern.js 1.62 kB 0 B
./.nuxt/dist/client/pages/search.js 5.19 kB +8 B (0%)
./.nuxt/dist/client/pages/search.modern.js 2.67 kB -1 B (0%)
./.nuxt/dist/client/pages/search/audio.js 6.15 kB -1 B (0%)
./.nuxt/dist/client/pages/search/audio.modern.js 3.65 kB 0 B
./.nuxt/dist/client/pages/search/image.js 659 B 0 B
./.nuxt/dist/client/pages/search/image.modern.js 2.73 kB -1 B (0%)
./.nuxt/dist/client/pages/search/index.js 543 B 0 B
./.nuxt/dist/client/pages/search/index.modern.js 547 B 0 B
./.nuxt/dist/client/pages/search/model-3d.js 243 B 0 B
./.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.js 266 B +1 B (0%)
./.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B +1 B (0%)
./.nuxt/dist/client/pages/search/video.js 239 B -1 B (0%)
./.nuxt/dist/client/pages/search/video.modern.js 243 B 0 B
./.nuxt/dist/client/pages/sources.js 1.56 kB +1 B (0%)
./.nuxt/dist/client/pages/sources.modern.js 1.55 kB 0 B
./.nuxt/dist/client/vendors/app.js 63.8 kB +2 B (0%)
./.nuxt/dist/client/vendors/app.modern.js 63.1 kB -1 B (0%)

compressed-size-action

zackkrida
zackkrida approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm seeing the correct changes locally (the new version is on the left):

CleanShot 2023-02-03 at 13 14 36

@WordPress WordPress deleted a comment from github-actions bot Feb 6, 2023
@obulat obulat force-pushed the fix/content_switcher_tabs branch 2 times, most recently from 8bd051e to fd311d8 Compare February 8, 2023 07:00
@obulat obulat force-pushed the fix/content_switcher_tabs branch from fd311d8 to fb88e76 Compare February 8, 2023 09:02
dhruvkb
dhruvkb approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, took me a while to notice the difference between "Content types" and "Content type" in the screenshots

@obulat
Copy link
Contributor Author

obulat commented Feb 8, 2023

LGTM, took me a while to notice the difference between "Content types" and "Content type" in the screenshots

Me too :)

@obulat obulat merged commit df016dd into main Feb 8, 2023
@obulat obulat deleted the fix/content_switcher_tabs branch February 8, 2023 10:13
github-actions bot pushed a commit that referenced this pull request Feb 8, 2023
@openverse-bot
Clean preview for PR #2140
8cfef1c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@zackkrida zackkrida zackkrida approved these changes

Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@obulat @zackkrida @dhruvkb @openverse-bot