-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter counter in button and tab #482
Filter counter in button and tab #482
Comments
Subscribe to Label Actioncc @WordPress/gutenberg-design, @WordPress/openverse
This issue or pull request has been labeled: "🖼️ aspect: design"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Nice work. I appreciate you've been able to unify the content type picker with the filter picker on mobile. On desktop it makes a ton of sense to replace the filter icon with the number of filters applied, because the label remains as context. I wish a similar pattern culd work on mobile, though I suppose the unread dot can work in its place. Perhaps an alternative would be to have the number shown to the left of the Settings icon? Related, the white background around the settings icon feels like a "holepunch" in the search box. I wonder if there's an opportunity there. Perhaps on mobile the settings icon rests, sans background, on the gray search input. When a filter is applied, it gets a boundary — white or gray or a border — and the boundary is extended leftwards to leave room to show the the number of filters applied. What do you think? It's nitpick territory, the dot works. |
Actually, it does not. The dot indicator points that "you applied" one or several filters, but not "how many" or "which ones." Think of the following scenario on mobile.
In the example, shifting to audio means that "License: CC0" remains, but there is no "Image size" criterion. For this we have two options:
In both cases we need to convey that filters changed. And the dot indicator is insufficient for that purpose. Even if we show the Filter counter next to the Settings button, I am afraid that it might not be fully visible. The change will happen in the background, behind the dark-opaque layer, while the focus is set on the drawer's content. Therefore, the drawer is the "safest" place to convey this info. |
This looks like a great way to reduce movement in the UI. It's a different issue, but I'd also like to consider a fixed width for the searchbar or the content switcher to prevent motion there as well. |
When designing the new header, I thought of a full-width search bar to avoid white spaces between the input and buttons. I assumed that filtering was a more typical action than shifting to another content type, so the motion effect is likely less visible. For the |
As mentioned during the weekly meeting, I will start preparing the assets for its implementation. |
The assets are ready to start the implementation ✨ Please start with the Design page to understand the proposal, the Mockups for the design specs, and Prototype whether you want to interact with the mobile view. I will update the initial message and status label for |
Problem
The new header simplifies its layout by grouping elements as the viewport goes smaller, but at the same time, it hides the counter label of filters applied when visitors play with the feature.
This element helps users to remember the criteria set to narrow the results, and to convey the filter reset when shifting to a content type that does not match the filter criteria. For this second case, it is crucial to be clear that filters are no longer applied in this new content type.
Due to these two reasons, it becomes necessary to bring back the value and make it consistent in both the filter button and the drawer.
Related issues
The problem was identified by @zackkrida in WordPress/openverse-frontend#1861
Proposal
Desktop flow.
lg
Filter.counter.XL.mp4
Mobile flow.
sm
Filter.counter.SM.mp4
Mockups
lg
sm
Description
Now that we can separate the counter from the string, replacing the filter icon with the counter solves the shaking effect of the width change in the header.
The design keeps the
24px
box for both filter icon and the counter across all breakpoints. For the filter button, the resting state hasdark-charcoal-10
as background color to match the search input, whereas the active state has no background.In the case of the drawer, both tabs have an icon visible all the time. The “Content type" tab shows the active content while “Filters” works as its desktop version to reach more consistency. Since both tabs show an icon, the label’s text style is
label regular
to reduce the layout contrast.In
lg
breakpoint, the counter has a background just in the icon-size area, while its active state has a background in the button-size area, as shown below.Since the design proposes to move the counter number into the drawer’s tab, there is no need to show it in the "Clear filters" action. In that vein, we reach consistency with its desktop version by showing the same element.
Feedback
The changes impact the drawer mostly, yet the tweaks make the flow more clear and consistent across breakpoints. What do you think of the idea?
Design assets
xs
breakpointThe text was updated successfully, but these errors were encountered: