Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot Tip: Use new placement prop instead of legacy position prop #68517

Conversation

himanshupathak95
Copy link
Contributor

What?

Part of #44401

Use the new placement prop instead of the legacy position prop to define the Popover's placement when it is opened.

Why?

With the recent refactoring of the Popover component to floating-ui, we're in the process of refactoring all of its usages to the new placement prop (native to floating-ui). See #44401 for more details

How?

Swap position with the new corresponding placement.

See this conversion table that we're currently using to map position values to placement values.

Testing Instructions

Screenshots or screencast

Before After

@Mamaduka
Copy link
Member

Mamaduka commented Jan 7, 2025

@himanshupathak95, the nux package is deprecated. I am not sure if there are any benefits to shipping enhancements for deprecate pages or components.

@himanshupathak95
Copy link
Contributor Author

Thanks @Mamaduka for the suggestion. I was unaware of the nux package being depreacted. In that case, maybe we can focus on other issues and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants