Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Remove unnecessary Tooltip component from linked button #68498

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: label name
  • Loading branch information
im3dabasia committed Jan 6, 2025
commit 9fcf9a8392c2e893861671b5c415c37624b82dcb
2 changes: 1 addition & 1 deletion packages/components/src/box-control/linked-button.tsx
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ export default function LinkedButton( {
isLinked,
...props
}: { isLinked?: boolean } & React.ComponentProps< typeof Button > ) {
const label = isLinked ? __( 'Unlink sides44' ) : __( 'Link sides' );
const label = isLinked ? __( 'Unlink sides' ) : __( 'Link sides' );

return (
<Button

Unchanged files with check annotations Beta

// Use arrow up/down to move through the list.
await page.keyboard.press( 'ArrowDown' );
await expect( page.getByLabel( 'Sample Page' ) ).toBeFocused();

Check failure on line 113 in test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js

GitHub Actions / Playwright - 5

[chromium] › site-editor/dataviews-list-layout-keyboard.spec.js:96:2 › Dataviews List Layout › Navigates the items list via UP/DOWN arrow keys

1) [chromium] › site-editor/dataviews-list-layout-keyboard.spec.js:96:2 › Dataviews List Layout › Navigates the items list via UP/DOWN arrow keys Error: Timed out 5000ms waiting for expect(locator).toBeFocused() Locator: getByLabel('Sample Page') Expected: focused Received: inactive Call log: - expect.toBeFocused with timeout 5000ms - waiting for getByLabel('Sample Page') - locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-148-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-148-label" aria-describedby="view-list-0-148-description"></button> - unexpected value "not focused" - locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-148-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-148-label" aria-describedby="view-list-0-148-description"></button> - unexpected value "not focused" - locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-148-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-148-label" aria-describedby="view-list-0-148-description"></button> - unexpected value "not focused" - locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-148-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-148-label" aria-describedby="view-list-0-148-description"></button> - unexpected value "not focused" - locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-148-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-148-label" aria-describedby="view-list-0-148-description"></button> - unexpected value "not focused" - locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-148-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-148-label" aria-describedby="view-list-0-148-description"></button> - unexpected value "not focused" - locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-148-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-148-label" aria-describedby="view-list-0-148-description"></button> - unexpected value "not focused" - locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-148-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-148-label" aria-describedby="view-list-0-148-description"></button> - unexpected value "not focused" - locator resolved to <button type="button" tabindex="-1" aria-pressed="false" id="view-list-0-148-item-wrapper" class="dataviews-view-list__item" aria-labelledby="view-list-0-148-label" aria-describedby="view-list-0-148-description"></button> - unexpected value "not focused" 111 | // Use arrow up/down to move through the list. 112 | await page.keyboard.press( 'ArrowDown' ); > 113 | await expect( page.getByLabel( 'Sample Page' ) ).toBeFocused(); | ^ 114 | 115 | await page.keyboard.press( 'ArrowUp' ); 116 | await expect( page.getByLabel( 'Privacy Policy' ) ).toBeFocused(); at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/dataviews-list-layout-keyboard.spec.js:113:52
await page.keyboard.press( 'ArrowUp' );
await expect( page.getByLabel( 'Privacy Policy' ) ).toBeFocused();