Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Surface the associated Menu name in the List View tab #68441

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

im3dabasia
Copy link
Contributor

@im3dabasia im3dabasia commented Jan 1, 2025

Fixes Point 1 of #68177

What?

This PR surfaces the name of the currently selected menu next to the word "Menu" in the Navigation block's List View tab, making it easier for users to identify which menu is associated with the block directly within the editor interface.

Why?

Currently, to identify which menu is linked to a Navigation block, users must navigate through multiple steps:

  1. Select the Navigation block,
  2. Open the block sidebar,
  3. Click on the List View tab,
  4. Open the 3-dot menu,
  5. See the currently selected menu.

This multi-step process can be cumbersome, especially for less experienced users. This change simplifies this by immediately displaying the menu name alongside the "Menu" label, improving discoverability and usability.

How?

This change uses the useNavigationMenu hook to display the current menu name next to the "Menu" label in the Navigation block's List View tab. The aim is to provide immediate feedback without overloading the UI.

Testing Instructions

  1. Open a post or page in the WordPress editor.
  2. Insert a Navigation block or select an existing one.
  3. Open the block sidebar.
  4. Switch to the "List View" tab.
  5. Verify that the name of the currently selected menu is displayed next to the "Menu" label.

Screencast

Screen.Recording.2025-01-01.at.1.21.31.PM.mov

@im3dabasia im3dabasia marked this pull request as ready for review January 1, 2025 07:54
Copy link

github-actions bot commented Jan 1, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

1 similar comment
Copy link

github-actions bot commented Jan 1, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Jan 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: yogeshbhutkar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@yogeshbhutkar
Copy link
Contributor

Thanks for the PR ✨. I've fixed the second point here.

@shail-mehta shail-mehta added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants