-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Standardize reduced motion handling using media queries #68424
base: trunk
Are you sure you want to change the base?
Editor: Standardize reduced motion handling using media queries #68424
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Could you rebase this PR to make sure it passes Check Storybook build on CI for PRs #68466?
- We should be able to remove this mixin.
Hi @t-hamano, Thanks for approving the PR. ✅ The storybook builds are successful
I will remove this in a follow-up PR which I am going to raise for this This PR is ready to be merged now 🚀 |
@himanshupathak95 Thanks for the update!
Is there any reason not to address this in this PR? If we don't remove this code in this PR, we will end up with redundant code like this: .editor-post-featured-image__actions {
&:not(.editor-post-featured-image__actions-missing-image) {
@include reduce-motion("transition");
@media not (prefers-reduced-motion) {
transition: opacity 50ms ease-out;
}
}
} |
@t-hamano, Thanks for the suggestion. I have removed the redundant mixin. |
Part of: #68282
What?
Replace all instances of the reduce-motion mixin with standardized
@media not (prefers-reduced-motion)
media queries across the editor package components to improve code consistency and maintainability.Testing Instructions
Test Document Bar and Tools:
Test Publish Panel:
Screencast
Screen.Recording.2025-01-01.at.15.35.12.mov
Screen.Recording.2025-01-01.at.15.36.33.mov
Screen.Recording.2025-01-01.at.15.38.17.mov