Navigation Submenu: Fix color handling and inheritance #68351
Conversation
…failing test case
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
@yogeshbhutkar Background color for sub menu block is not getting applied I think, Can you recheck?
https://github.com/user-attachments/assets/c561b8c3-cf34-41db-9fa9-effd6511aaa2
| @@ -99,6 +99,16 @@ function render_block_core_navigation_submenu( $attributes, $content, $block ) { | |||
| $open_on_hover_and_click = isset( $block->context['openSubmenusOnClick'] ) && ! $block->context['openSubmenusOnClick'] && | |||
| $show_submenu_indicators; | |||
|
|
|||
| $block->block_type->supports['color'] = true; | |||
There was a problem hiding this comment.
Repeated again on line 258, is there a reason we need to set twice?
There was a problem hiding this comment.
The repetition on line 258 could be omitted safely. Will be done in the next commit. Thanks for the suggestion.
| 'has-background': !! backgroundColor || customBackgroundColor, | ||
| [ getColorClassName( 'background-color', backgroundColor ) ]: | ||
| !! backgroundColor, | ||
| 'has-text-color': !! _textColor || !! _customTextColor, |
There was a problem hiding this comment.
"textColor": {
"type": "string"
},Since its a string, I feel this is a little less readable on first glance.
Maybe adding a explicit check might be better?
'has-text-color': Boolean(_textColor || _customTextColor),There was a problem hiding this comment.
I think the Double Bang operator conveys the boolean nature and should provide sufficient context.
There was a problem hiding this comment.
Fair enough, but the original included two comparisons, whereas this approach reduces it to just one.
Mamaduka
added
[Type] Bug
What, Why & How?
Testing Instructions for Keyboard
Screencasts
The following are the expected outcomes that the submenu block should abide by.
If the
navigation blockhas either abackgroundor atextcolor assigned, and there's no color provided for thesubmenu & overlay textorsubmenu & overlay background, thennavigationblocks color should be inherited. ( ✅ )If the
navigation blockhas specified a color, but, thesubmenu parenthas also specified a color (background and text ), the submenu container should still inherit the color from thenavigation block. ( ✅ )If
submenu & overlay textorsubmenu & overlay backgroundvalues are provided, these should overwrite the values ofnavigation block. ( ✅ )if only
submenu'scolor and background value are passed, then it shouldn't override the value of thesubmenu container.Container'svalues must be either inherited fromnavigationor from the dedicatedsubmenucontrol options onnavigation. ( ✅ )Closes: #68350